Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERVICES-2588] Deanonymize query in metrics plugin #1473

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[SERVICES-2588] Deanonymize query in metrics plugin #1473

merged 1 commit into from
Sep 17, 2024

Conversation

mad2sm0key
Copy link
Contributor

Reasoning

  • Currently, in cases where operationName is not, a SHA-256 hash is used for metrics. This completely hides the underlying queries

Proposed Changes

  • Extract the schema query names from the document exposed on GraphQLRequestContext inside the metrics plugin

How to test

  • N/A

@claudiulataretu claudiulataretu merged commit 10f6f34 into development Sep 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioandanpopa ioandanpopa ioandanpopa approved these changes

@claudiulataretu claudiulataretu claudiulataretu approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mad2sm0key @ioandanpopa @claudiulataretu @bogdan-rosianu