Exchange Deployer #62
Conversation
|
Contract comparison - from 6436375 to 66c1591
|
| reward_token_id, | ||
| farming_token_id, | ||
| division_safety_constant, | ||
| pair_contract_address, |
There was a problem hiding this comment.
why is the pair contract needed ?
There was a problem hiding this comment.
I don't know, the farm requests it on deploy. My guess is it sends the tokens there instead of burning them if it can.
| fn deployed_contracts( | ||
| &self, | ||
| user_address: &ManagedAddress, | ||
| ) -> UnorderedSetMapper<ManagedAddress>; |
There was a problem hiding this comment.
All the deployed contracts are stored here, but there is no info about the SC type. Should there be a info stored for each deployed address that specify the SC type?
| .execute_on_dest_context(); | ||
| } | ||
|
|
||
| #[endpoint(proxyDexSetTransferRoleWrappedLpToken)] |
There was a problem hiding this comment.
Anyone can call these endpoints? Is this safe?
There was a problem hiding this comment.
Only the deployer of the contract can call this:
self.require_deployed_contract(&caller, &proxy_dex_address);
| /// `0` - SimpleFarm - rewards are fungible tokens | ||
| /// `1` - FarmWithLockedRewards - rewards are META ESDT locked tokens | ||
| #[endpoint(simpleLockAddFarmToWhitelist)] | ||
| fn simple_lock_add_farm_to_whitelist( |
There was a problem hiding this comment.
Same. Maybe some admin roles?
|
|
||
| #[multiversx_sc::module] | ||
| pub trait CommonModule { | ||
| fn get_default_code_metadata(&self) -> CodeMetadata { |
There was a problem hiding this comment.
Receive the address as a parameter and use the new get_code_metadata() framework function instead.
There was a problem hiding this comment.
Nope, no address as parameter, this is just the default value I use.
| + multiversx_sc_modules::pause::PauseModule | ||
| { | ||
| #[init] | ||
| fn init( |
There was a problem hiding this comment.
Why not store all these addresses unde the same storage, but using a DeployActionType enum value as the key. You will remove a lot of different storages.
There was a problem hiding this comment.
Something like the customActionFee storage.
| #[view(getActionFee)] | ||
| fn get_action_fee(&self, action_type: DeployActionType) -> BigUint { | ||
| let custom_fee = self.custom_action_fee(action_type).get(); | ||
| if custom_fee > 0 { |
There was a problem hiding this comment.
Was this a request? This means that you cannot have 0 fee, even if you wanted to.
| } | ||
|
|
||
| #[storage_mapper("deployedContracts")] | ||
| fn deployed_contracts( |
There was a problem hiding this comment.
Indeed, from what I saw from the general ProxyDeployer SC, having the information about all the deployed contracts of a specific type would be very helpful (for the microservice). Maybe add a new storage, as Costin suggested, having all the deployed contracts under a contract type key.
| pub mod fee; | ||
|
|
||
| #[multiversx_sc::contract] | ||
| pub trait ExchangeDeployer: |
There was a problem hiding this comment.
I think we should have an only_owner endpoint, that allows the owner of the exchange deployer to call any only_owner endpoint of the deployed contracts. Right now you can only deploy SCs and maybe whitelist the deployer as an admin. But in case we want to remove the deployer from the admin whitelist (for being malicious let's say), you cannot do so. And this extends to all kinds of use cases, where we want to call owner endpoints.
No description provided.