Liquid staking sc #121
Draft
Liquid staking sc #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
alyn509
requested changes
Sep 13, 2024
| @@ -0,0 +1,4 @@ | |||
| use multiversx_sc::imports::*; | |||
| { | ||
| #[init] | ||
| fn init(&self, delegation_address: ManagedAddress) { | ||
| require!( |
There was a problem hiding this comment.
better extract this into a function / endpoint add_delegation_contract. In the future you might have this contract working with more than 1 delegation contract.
There was a problem hiding this comment.
alright, in this case I will make the storage mapper to a UnorderedSetMapper
There was a problem hiding this comment.
Nevermind, this won't work, I created a SingleValueMapper with an index as contract_name
liquid-staking/src/delegation.rs
Outdated
Comment on lines
55
to
70
| #[callback] | ||
| fn stake_callback( | ||
| &self, | ||
| caller: &ManagedAddress, | ||
| egld_amount: &BigUint, | ||
| #[call_result] result: ManagedAsyncCallResult<()>, | ||
| ) { | ||
| match result { | ||
| ManagedAsyncCallResult::Ok(()) => { | ||
| self.delegated_value(caller.clone()).set(egld_amount); | ||
| self.egld_token_supply() | ||
| .update(|value| *value += egld_amount) | ||
| } | ||
| _ => sc_panic!("There was an error at delegating"), | ||
| } | ||
| } |
There was a problem hiding this comment.
just a small advice to ease code reading: put every callback after the endpoint that calls it
liquid-staking/src/delegation.rs
Outdated
| let current_epoch = self.blockchain().get_block_epoch(); | ||
| let total_egld_deposit = self.delegated_value(caller.clone()).get(); | ||
| let delegation_contract_address = self.delegation_address().get(); | ||
| let undelegate_endpoint = ManagedBuffer::from("unDelegate"); |
liquid-staking/src/delegation.rs
Outdated
|
|
||
| let mut args: ManagedArgBuffer<Self::Api> = ManagedArgBuffer::new(); | ||
| args.push_arg(&egld_amount_to_unstake); | ||
|
|
There was a problem hiding this comment.
I feel like it is way better to make a check here if caller has something to unstake, by checking that the amount to unstake is available in delegated_value
in this way you will not call undelegate if you already know that the caller hasn't enough to unstake
| "tx": { | ||
| "from": "address:owner", | ||
| "contractCode": "mxsc:../output/liquid-staking.mxsc.json", | ||
| "arguments": [], |
There was a problem hiding this comment.
There are no init args at the moment
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from ae4bca4 to a0874cf
|
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Liquid staking unit tests setup
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Update actions.yml contracts v3.3.1
Liquid Staking upgrade to 0.53.1
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Liquid-Staking fixes after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.