refactor child contracts #4
Conversation
| ticker: ManagedBuffer, | ||
| opt_default_price_per_gas_unit: OptionalValue<BigUint>, | ||
| ) { | ||
| fn add_token_to_whitelist(&self, token_id: TokenIdentifier, ticker: ManagedBuffer) { |
There was a problem hiding this comment.
Can you extract ticker from token_id so token_ticker storage would not be necessary?
There was a problem hiding this comment.
Actually, we likely don't need ticker at all anymore. Future PR.
| #[derive( | ||
| TopDecode, TopEncode, NestedDecode, NestedEncode, TypeAbi, Debug, ManagedVecItem, Clone, | ||
| )] | ||
| pub struct StolenFromFrameworkEsdtTokenData<M: ManagedTypeApi> { |
There was a problem hiding this comment.
Can you rename StolenFromFrameworkEsdtTokenData?
There was a problem hiding this comment.
It will be introduced in framework in the next version. Will be deleted then :)
| self.burn_esdt_token(&tx.token_identifier, &tx.amount); | ||
| for token in &tx.tokens { | ||
| if self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::Burn) { | ||
| self.send().esdt_local_burn( |
There was a problem hiding this comment.
Does the esdt-safe SC have the roles to burn any deposited token?
There was a problem hiding this comment.
That's why it's checked first :)
| @@ -41,15 +42,10 @@ pub trait EsdtSafe: | |||
| self.first_batch_id().set_if_empty(1); | |||
There was a problem hiding this comment.
I think first_batch_id should be renamed with current_batch_id
There was a problem hiding this comment.
Eh, maybe, but not for now. Let's leave it as it is.
| @@ -103,50 +106,30 @@ pub trait EsdtSafe: | |||
| self.clear_first_batch(&mut tx_batch); | |||
| } | |||
|
|
|||
| /// Converts failed Ethereum -> Elrond transactions to Elrond -> Ethereum transaction. | |||
There was a problem hiding this comment.
The rebranding can be done by someone else :)
|
|
||
| let own_sc_address = self.blockchain().get_sc_address(); | ||
| let mut all_token_data = ManagedVec::new(); | ||
| for payment in &payments { |
There was a problem hiding this comment.
Verify gas consumption in case of too many payments.
There was a problem hiding this comment.
There is a max transfer limit and a max gas limit too in a future PR.
| @@ -229,12 +226,19 @@ pub trait EsdtSafe: | |||
| fn get_refund_amounts( | |||
| &self, | |||
| address: ManagedAddress, | |||
| ) -> MultiValueEncoded<MultiValue2<TokenIdentifier, BigUint>> { | |||
| ) -> MultiValueEncoded<MultiValue3<TokenIdentifier, u64, BigUint>> { | |||
| let mut refund_amounts = MultiValueEncoded::new(); | |||
| for token_id in self.token_whitelist().iter() { | |||
There was a problem hiding this comment.
Save self.token_whitelist() in a variable.
There was a problem hiding this comment.
No need, the call is done only once.
| let mut tokens_to_send = ManagedVec::new(); | ||
| let mut sent_token_data = ManagedVec::new(); | ||
|
|
||
| for (token, opt_token_data) in sov_tx.tokens.iter().zip(sov_tx.token_data.iter()) { |
There was a problem hiding this comment.
create a variable for sov_tx.tokens.iter().zip(sov_tx.token_data.iter())
There was a problem hiding this comment.
No need again, it's only called once.
Multi-sig SC will be fixed in a future PR.