Skip to content

fix multisig

fix multisig #9

GitHub Actions / clippy succeeded Oct 11, 2023 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (2)

multi-transfer-esdt/src/lib.rs|135 col 16| warning: this else { if .. } block can be collapsed
--> multi-transfer-esdt/src/lib.rs:135:16
|
135 | } else {
| ^
136 | | if !self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::NftCreate) {
137 | | self.transfer_failed_invalid_token(batch_id, tx_nonce);
138 | |
... |
146 | | }
147 | | }
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: #[warn(clippy::collapsible_else_if)] on by default
help: collapse nested if block
|
135 ~ } else if !self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::NftCreate) {
136 + self.transfer_failed_invalid_token(batch_id, tx_nonce);
137 +
138 + return true;
139 + } else if token.amount > NFT_AMOUNT
140 + && !self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::NftAddQuantity)
141 + {
142 + self.transfer_failed_invalid_token(batch_id, tx_nonce);
143 +
144 + return true;
145 + }
|
multi-transfer-esdt/src/lib.rs|136 col 92| error: this if has identical blocks
--> multi-transfer-esdt/src/lib.rs:136:92
|
136 | if !self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::NftCreate) {
| ____________________________________________________________________________________________^
137 | | self.transfer_failed_invalid_token(batch_id, tx_nonce);
138 | |
139 | | return true;
140 | | } else if token.amount > NFT_AMOUNT
| |
^
|
note: same as this
--> multi-transfer-esdt/src/lib.rs:142:13
|
142 | / {
143 | | self.transfer_failed_invalid_token(batch_id, tx_nonce);
144 | |
145 | | return true;
146 | | }
| |
_______^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
= note: #[deny(clippy::if_same_then_else)] on by default