Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows client crash 1.5.735 #6659

Closed
Scar1943 opened this issue Dec 9, 2024 · 25 comments
Closed

Windows client crash 1.5.735 #6659

Scar1943 opened this issue Dec 9, 2024 · 25 comments
Labels
bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members

Comments

@Scar1943
Copy link

Scar1943 commented Dec 9, 2024

Description

A hand full of my client installs that worked fine on 1.5.634 crash after 1.5.735 upgrade. It's NOT on every machine, only a hand full of windows 10 and windows 11 desktops. A removal and reinstall of 1.5.634 resolves the crash. Crash consists of just a flash of the dialog box, and vanish of the app. An occasional "crash report dialog" which I have filled out and sent in. Machines are both windows 11 pro and windows 10 pro machines. Are there newer windows libraries that are needed with the update?

Steps to reproduce

Use the update server stated in the start of the client.
Download the update.
Install the update.
Attempt to start mumble.

Mumble version

1.5.735

Mumble component

Client

OS

Windows

Reproducible?

Yes

Additional information

I get the impression it is a library update that some of my older machines may not have? Can we get some info (if that is what it is) and perhaps a library download link.

Relevant log output

No response

Screenshots

No response

@Scar1943 Scar1943 added bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels Dec 9, 2024
@Tekwizz
Copy link

Tekwizz commented Dec 9, 2024

Hahaha, I was just going to login last night to report this exact same thing, but was delayed due to 2FA. Thanks for beating me to it, and that's exactly what happened to me, on a recently fully updated (last week) Win10 machine.

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Dec 9, 2024

Are all affected machines using the same Windows version? And do all machines have the same Visual C++ redistributable libraries installed?

Does a complete removal and fresh install of 1.5.735 lead to a working Mumble installation?

flash of the dialog box

Which one? The server browser?

@Hartmnt
Copy link
Member

Hartmnt commented Dec 9, 2024

This is 99.9% caused by #6648 confirmed to be good down below

At this point we need a stack trace and probably @davidebeatrici 🥲

@Porkepix
Copy link

Porkepix commented Dec 9, 2024

I discussed a lot that issue with @Hartmnt on Matrix today, so I provided the information I could. Unfortunately some things are localized and there doesn't seems to be an easy way to get this in English on Windows, so I can help if some things are an issue to understand (or someone maybe have its OS in English and can do the same thing as me).

Console file for a fresh start with the problematic build ``` 2024-12-09 10:04:46.913 Loading legacy settings from the registry 2024-12-09 10:04:46.942 G15LCDEngine_lglcd: Logitech LCD Manager not detected. 2024-12-09 10:04:46.947 Theme: "Mumble" 2024-12-09 10:04:46.947 Style: "Lite" 2024-12-09 10:04:46.947 --> qss: ":themes/Default/Lite.qss" 2024-12-09 10:04:46.947 Locale is "fr_FR" (System: "fr_FR") 2024-12-09 10:04:47.545 Database SQLite: "3.43.2" 2024-12-09 10:04:47.601 Updating application palette 2024-12-09 10:04:47.620 XboxInput: using XInput DLL 'XInput1_4.dll' 2024-12-09 10:04:47.620 XboxInput: using XInputGetStateEx() as querying function. 2024-12-09 10:04:48.635 QMetaObject::connectSlotsByName: No matching signal for on_qtvUsers_customContextMenuRequested(QPoint,bool) 2024-12-09 10:04:48.635 QMetaObject::connectSlotsByName: No matching signal for on_muteCuePopup_triggered() 2024-12-09 10:04:49.665 AudioInput: Opus encoder set for high quality speech 2024-12-09 10:04:49.666 AudioInput: 40000 bits/s, 48000 hz, 480 sample 2024-12-09 10:04:49.671 WASAPIInput: Latencies 100000 30000 => 100000 2024-12-09 10:04:49.675 WASAPIOutput: Latencies 100000 30000 => 100000 2024-12-09 10:04:49.707 WASAPIOutput: Output stream format 1 2024-12-09 10:04:49.707 WASAPIOutput: Stream Latency 0 (2880) 2024-12-09 10:04:49.707 WASAPIOutput: Periods 10000us 3000us (latency 0us) 2024-12-09 10:04:49.707 WASAPIOutput: Buffer is 60000us (5) 2024-12-09 10:04:49.708 AudioOutput: Initialized 2 channel 48000 hz mixer 2024-12-09 10:04:49.737 WASAPIInput: Mic Stream format 1 2024-12-09 10:04:49.738 WASAPIInput: Stream Latency 0 (1056) 2024-12-09 10:04:49.741 AudioInput: Initialized mixer for 2 channel 48000 hz mic and 0 channel 48000 hz echo ```
Notice message in the events log monitor related to the crash
Nom du journal :Application
Source :       Windows Error Reporting
Date :         09/12/2024 12:50:27
ID de l’événement :1001
Catégorie de la tâche :Aucun
Niveau :       Information
Mots clés :    Classique
Utilisateur :  N/A
Ordinateur :   DESKTOP-2LA1R3K
Description :
Détecteur d'erreurs 2263337952031124081, type 4
Nom d’événement : APPCRASH
Réponse : Non disponible
ID de CAB : 0

Signature du problème : 
P1 : mumble.exe
P2 : 1.5.735.0
P3 : 67531562
P4 : MSVCP140.dll
P5 : 14.32.31332.0
P6 : 8b64702c
P7 : c0000005
P8 : 00000000000132f8
P9 : 
P10 : 

Fichiers joints :
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERD80C.tmp.dmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERDCE0.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERDE48.tmp.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERDE65.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERDEC4.tmp.txt

Ces fichiers sont peut-être disponibles ici :
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_mumble.exe_6c207e22de7546d2e6fd2fda43e93a83301e44ae_e23bdde6_3d62aa2f-d466-4c84-989b-ad2dd93ba13a

Symbole d’analyse : 
Nouvelle recherche de la solution : 0
ID de rapport : 821a7dee-60d2-44ec-a81d-9103dba8db59
Statut du rapport : 268435456
Récipient avec hachage : 711f6d2683a51085bf68fde02d79aa71
GUID CAB :0
XML de l’événement :
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Windows Error Reporting" />
    <EventID Qualifiers="0">1001</EventID>
    <Version>0</Version>
    <Level>4</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2024-12-09T11:50:27.7253456Z" />
    <EventRecordID>122383</EventRecordID>
    <Correlation />
    <Execution ProcessID="0" ThreadID="0" />
    <Channel>Application</Channel>
    <Computer>DESKTOP-2LA1R3K</Computer>
    <Security />
  </System>
  <EventData>
    <Data>2263337952031124081</Data>
    <Data>4</Data>
    <Data>APPCRASH</Data>
    <Data>Non disponible</Data>
    <Data>0</Data>
    <Data>mumble.exe</Data>
    <Data>1.5.735.0</Data>
    <Data>67531562</Data>
    <Data>MSVCP140.dll</Data>
    <Data>14.32.31332.0</Data>
    <Data>8b64702c</Data>
    <Data>c0000005</Data>
    <Data>00000000000132f8</Data>
    <Data>
    </Data>
    <Data>
    </Data>
    <Data>
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERD80C.tmp.dmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERDCE0.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERDE48.tmp.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERDE65.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERDEC4.tmp.txt</Data>
    <Data>\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_mumble.exe_6c207e22de7546d2e6fd2fda43e93a83301e44ae_e23bdde6_3d62aa2f-d466-4c84-989b-ad2dd93ba13a</Data>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>821a7dee-60d2-44ec-a81d-9103dba8db59</Data>
    <Data>268435456</Data>
    <Data>711f6d2683a51085bf68fde02d79aa71</Data>
    <Data>0</Data>
  </EventData>
</Event>
Error message in the events log monitor related to the crash
Nom du journal :Application
Source :       Application Error
Date :         09/12/2024 12:50:22
ID de l’événement :1000
Catégorie de la tâche :(100)
Niveau :       Erreur
Mots clés :    Classique
Utilisateur :  N/A
Ordinateur :   DESKTOP-2LA1R3K
Description :
Nom de l’application défaillante mumble.exe, version : 1.5.735.0, horodatage : 0x67531562
Nom du module défaillant : MSVCP140.dll, version : 14.32.31332.0, horodatage : 0x8b64702c
Code d’exception : 0xc0000005
Décalage d’erreur : 0x00000000000132f8
ID du processus défaillant : 0x1b20
Heure de début de l’application défaillante : 0x01db4a307be75653
Chemin d’accès de l’application défaillante : C:\Program Files\Mumble\client\mumble.exe
Chemin d’accès du module défaillant: C:\WINDOWS\SYSTEM32\MSVCP140.dll
ID de rapport : 821a7dee-60d2-44ec-a81d-9103dba8db59
Nom complet du package défaillant : 
ID de l’application relative au package défaillant : 
XML de l’événement :
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Application Error" />
    <EventID Qualifiers="0">1000</EventID>
    <Version>0</Version>
    <Level>2</Level>
    <Task>100</Task>
    <Opcode>0</Opcode>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2024-12-09T11:50:22.3289266Z" />
    <EventRecordID>122382</EventRecordID>
    <Correlation />
    <Execution ProcessID="0" ThreadID="0" />
    <Channel>Application</Channel>
    <Computer>DESKTOP-2LA1R3K</Computer>
    <Security />
  </System>
  <EventData>
    <Data>mumble.exe</Data>
    <Data>1.5.735.0</Data>
    <Data>67531562</Data>
    <Data>MSVCP140.dll</Data>
    <Data>14.32.31332.0</Data>
    <Data>8b64702c</Data>
    <Data>c0000005</Data>
    <Data>00000000000132f8</Data>
    <Data>1b20</Data>
    <Data>01db4a307be75653</Data>
    <Data>C:\Program Files\Mumble\client\mumble.exe</Data>
    <Data>C:\WINDOWS\SYSTEM32\MSVCP140.dll</Data>
    <Data>821a7dee-60d2-44ec-a81d-9103dba8db59</Data>
    <Data>
    </Data>
    <Data>
    </Data>
  </EventData>
</Event>

Finally, the WER archive report corresponding to those messages: https://drop.infini.fr/r/EZFqAAt5j5#7OO1Pt7HAbuFvmyM3NufbQd2fyd4xRATYrMmzvLCV08= (it seems GitHub disallow the upload of this file, dunno why. I've set file lifetime to the maximum allowed by the service: 45 days)

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Dec 9, 2024

I found conan-io/conan-center-index#9546 but I would hope this is not the case in our case...

We should check whether the crash also happens with 1.6 snapshots. I would hope not.
If this is indeed the case, we could instead refactor the 1.5 code to go all-Qt for the filesystem handling instead of using boost filesystem.

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Dec 9, 2024

Error code 0xc0000005 means Access violation so my best guess would be that we are referencing an invalid (null?) pointer somewhere.

@Hartmnt
Copy link
Member

Hartmnt commented Dec 9, 2024

@Tekwizz @Scar1943 Hi, here is an experimental build without our Unicode changes. Could you please check, if this experimental build also crashes? Note: I would not recommend using this as a daily driver. https://dev.azure.com/Mumble-VoIP/c819eb06-7b22-4ef3-bbcd-860094454eb3/_apis/build/builds/8981/artifacts?artifactName=Windows%20%28x64%29%20installer&api-version=7.1&%24format=zip

Edit: For completeness and future reference, this is 56d44cc

@Tekwizz
Copy link

Tekwizz commented Dec 9, 2024

Hi Harmnt, I just tried installing this 1.6.277 client on the same machine, and same situation, it disappears after two windows come up white for a moment, just like as with the 1.5.735 build.

@Scar1943
Copy link
Author

Scar1943 commented Dec 9, 2024

I did try obvious things like running the client as admin, reinstall, etc. It does seem to be related to "older" windows 11 and 10. All my up to day windows 11 machines run fine. Windows 10, even current, won't run it. "FEELS LIKE" a windows library that isn't updated in 10, and odd windows 11 installs. Just a gut feeling.

@Scar1943
Copy link
Author

Scar1943 commented Dec 9, 2024

@Tekwizz @Scar1943 Hi, here is an experimental build without our Unicode changes. Could you please check, if this experimental build also crashes? Note: I would not recommend using this as a daily driver. https://dev.azure.com/Mumble-VoIP/c819eb06-7b22-4ef3-bbcd-860094454eb3/_apis/build/builds/8981/artifacts?artifactName=Windows%20%28x64%29%20installer&api-version=7.1&%24format=zip

Edit: For completeness and future reference, this is 56d44cc

Sorry, no difference. Thankfully, a windows uninstall, and reinstall of 634 is pretty easy to correct it. Did the new release require a newer version of some windows library that microsoft has dropped except in up to date 11 machines?

Just in case it's somehow relevant, the server 1.5.735 works fine on the server machines that crash the client. My server machines are old dell xeon E3 1270's. Not sure what else you need. Windows 10 pro 232H OS build 19045.5198. As current as microsoft will allow.

@Tekwizz
Copy link

Tekwizz commented Dec 9, 2024

The machine it's crashing on here, is an AMD A8 PRO-7600B Windows 10 22H2 build 19045.5011, yeah removing and reinstalling 634 is the fix so far. Well, yeah, I agree it does sound like dependency that's not being updated in Win 10.

@Scar1943
Copy link
Author

Scar1943 commented Dec 10, 2024

Ok folks, looks like its the C++ 2022 Redistributable x64

Once I install that with the dowload page link, it seems to have resolved the problem with all my windows 10 machines.

https://aka.ms/vs/17/release/vc_redist.x64.exe

All my machine clients are now working. So, the download page shows the requirement, but the download from the client isn't showing that as needed, nor is verifying it's installed. Unless you go to the download page, you won't realize it's needed.

@Krzmbrzl
Copy link
Member

nor is verifying it's installed.

#5549

@Porkepix
Copy link

Verified as fixed once the Redistributables got installed.
But yeah, those should probably embedded with the setup if required. And it's questionnable why the OS didn't update those with Windows Update.

@Hartmnt
Copy link
Member

Hartmnt commented Dec 10, 2024

Damn in previous versions, the problem would manifest itself with a message box saying something like "MSVCP.dll not found" which was pretty easy to link towards missing dependencies.

I guess its very unfortunate that it now silently crashes... I guess we really have to somehow fix the installer for the next version.

@Hartmnt Hartmnt closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
@Porkepix
Copy link

Damn in previous versions, the problem would manifest itself with a message box saying something like "MSVCP.dll not found" which was pretty easy to link towards missing dependencies.

I guess its very unfortunate that it now silently crashes... I guess we really have to somehow fix the installer for the next version.

I don't know if Windows users are a big part of the userbase, but I think it'd be a good idea to pin this issue or a similar one where users could find the answer to their problem until a better solution is found, or that at least some time goes by.

@Krzmbrzl
Copy link
Member

I don't think pinning an issue would really help...

@Porkepix
Copy link

I don't think pinning an issue would really help...

Well, the goal is only to avoid people opening multiple dupe issues, and for people to easily find the solution/workaround until there's something better; that's something I've oftentimes seen used.

@Krzmbrzl
Copy link
Member

Well, if you are having a crash, you won't think by yourself that Installer doesn't install VC++ redistributable is the issue you are seeing. However, the issue title is correct in that it properly describes what the issue is, albeit not the exact symptom that can be caused by it. That is to say that I don't think renaming the issue would be the correct solution here.

@Porkepix
Copy link

Well, if you are having a crash, you won't think by yourself that Installer doesn't install VC++ redistributable is the issue you are seeing. However, the issue title is correct in that it properly describes what the issue is, albeit not the exact symptom that can be caused by it. That is to say that I don't think renaming the issue would be the correct solution here.

It seems I wasn't clear enough with my suggestion. What I meant was just to pin this one to make it clearly visible for some time, or to pin another new locked one for the sole purpose of it being an informative message to affected users that would seek information/to open a new issue.

Of course, it makes more sense if say a substantial enough amount of users are affected (say, 5/10+%) and not a very small amount.

@Krzmbrzl
Copy link
Member

Oh. Okay now I get it 💡
Yes indeed, that seems to make sense 👍

@Krzmbrzl Krzmbrzl pinned this issue Dec 10, 2024
@davidebeatrici
Copy link
Member

This could potentially be related to appveyor/ci#3937.

I suspect ABI breakage in @microsoft's Visual C++.

@Tekwizz
Copy link

Tekwizz commented Dec 10, 2024

I'll confirm that as soon as I updated the Visual C++ library, without even a reboot, 1.5.735 runs fine!

The update:
14.32.31326 (5/8/2023)
14.42.34433

Funny that Windows update doesn't bother to update this...

Update: Also crashes in the same way on a quite new Win11 system, where the Visual C is 2015-2022 14.32.31332 (05-28-2024) Apparently this isn't being updated with Windows updates.

@davidebeatrici
Copy link
Member

Ideally the Visual C++ Runtime should be updated automatically, indeed, especially for security reasons.

In this specific case the lack of updates is even worse because the crash appears to be caused by a null pointer dereference.

@Hunweibyn
Copy link

Had same problem and reinstalling Visual C++ Runtime helped me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members
Projects
None yet
Development

No branches or pull requests

7 participants