Updating project files to iOS 6 and fixing build settings

[CaseyB]

Getting these settings right took me a long time and it seems there are a lot of people having trouble with it so I updated the project files.

[mkrautz]

Can you explain the rationale behind this pull request?

I have no problems with the current state of MumbleKit when I use it in Mumble for iOS, and the diffs in your PR seem fairly small (updating the deployment target and fixing archs).

Is the problem that MumbleKit doesn't build for enough architectures? (I.e., no armv7s and/or arm64?). Or something else?

Also: I'd like not to set the deployment target to 7, because in Mumble for iOS, we still deploy down to iOS 5.

Thanks.

[CaseyB]

Yes, that was exactly the problem. We are targeting iOS7 and mumblekit
wasn't building correctly for it. I had to change the arch type and in
order to do that I needed to bump up the minimum version. I think it only
needed to be 5.1.1 but since we were targeting iOS7 and up I just made it
match. I also had to set the Skip Install property to YES otherwise it
produced a Generic Xcode Archive instead of an iOS Archive.

Casey Borders

On Mon, Mar 24, 2014 at 2:22 PM, Mikkel Krautz [email protected]:

Can you explain the rationale behind this pull request?

I have no problems with the current state of MumbleKit when I use it in
Mumble for iOS, and the diffs in your PR seem fairly small (updating the
deployment target and fixing archs).

Is the problem that MumbleKit doesn't build for enough architectures?
(I.e., no armv7s and/or arm64?). Or something else?

Also: I'd like not to set the deployment target to 7, because in Mumble
for iOS, we still deploy down to iOS 5.

Thanks.

Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-38481366
.

[mkrautz]

Casey,

I had planned to update MumbleKit to be compatible with iOS 7 $STANDARD_ARCHS (armv7 armv7s arm64).

However, when I set out to do it last week, I found some problematic NSInteger -> int (and the like) conversions throughout the tree. I'd like to get those fixed before the ARCHS setting is updated.

Also, we try to keep most of our .xcodeproj configuration in .xcconfig files. See the cfg folder at the top of the source tree for MumbleKit's .xcconfigs. The .xcconfigs for third party libs are in the 3rdparty directory, in the "build" directory for each dependency.

I'd prefer that the ARCHS be updated in those files, instead of the .xcodeprojs. Same goes for SKIP_INSTALL.

But before we do that, we should manually vet all the 64-bit problems I discussed above.

[mkrautz]

Hi @CaseyB,

I have now committed arm64 support, as well as added armv7s support to MumbleKit's build:

95b46a5
6ec99df

I do not see the "Generic Xcode Archive" vs. "iOS Archive" issue your SKIP_INSTALL step was supposed to fix. Can you elaborate a bit on where/when you saw that problem? Thanks.

[CaseyB]

Wonderful. Honestly I was trying many different things to try to fix the
issue so I'm not 100% certain that the skip install update is needed.
Thank you so much for getting this in so quickly!
On Apr 6, 2014 2:38 PM, "Mikkel Krautz" [email protected] wrote:

Hi @CaseyB https://github.com/CaseyB,

I have now committed arm64 support, as well as added armv7s support to
MumbleKit's build:

95b46a595b46a5
6ec99dfhttps://github.com/mumble-voip/mumblekit/commit/6ec99df6310673997a60805e2a10a5f06248c3a7

I do not see the "Generic Xcode Archive" vs. "iOS Archive" issue your
SKIP_INSTALL step was supposed to fix. Can you elaborate a bit on
where/when you saw that problem? Thanks.

Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-39676272
.