Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MKUser.h #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update MKUser.h #30

wants to merge 1 commit into from

Conversation

vodaion
Copy link

@vodaion vodaion commented Dec 11, 2014

Fix error: Cannot find interface declaration for 'NSObject', superclass of 'MKUser'

Fix error: Cannot find interface declaration for 'NSObject', superclass of 'MKUser'
@mkrautz
Copy link
Contributor

mkrautz commented Dec 11, 2014

Hi @vadeara,

Thank you very much for the patch.

The reason the headers don't include Foundation.h is that both MumbleKit and Mumble for iOS have Foundation.h in their precompiled headers list.

Obviously, this doesn't necessarily work for other apps. However, instead of adding Foundation.h headers to all headers in the MumbleKit module, I think that we should encourage a single header for the module, <MumbleKit/MumbleKit.h>. This header includes all the MK*.h headers, but also ensures that Foundation.h and other deps are included before them.

So, I'll NAK this incarnation of the patch. Are you interested in contributing a MumbleKit.h header as described above? If not, I'll do it myself. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants