Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for connecting to Murmur via gRPC instead of Ice.
Almost all of the Murmur Ice API is bridged to gRPC and existing modules do not need to be changed (and neither do future ones, they should continue to use the Ice API).
Modules that rely on specific exception being thrown by Ice might have a hard time because gRPC exceptions are mostly passed through the bridge instead of being transformed into their Ice counterparts. I'm not aware of any modules actually doing that though.
Tested with
idlemove
,onjoin
,samplecontext
,seen
, (partially)source
,setstatus
andgmod
.Ice methods not used by any of these have been tested in the REPL but their return values might not be exactly what modules expect (I merely compared them to the docs, not to ones from an actual Ice client).