Chore untenantize #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luchotc
commented
Apr 20, 2021
| @@ -47,6 +47,10 @@ class Basic < Mumukit::Platform::Application | |||
| def organic_uri(_organization) | |||
| uri | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
I don't think that Basic apps need to respond to that method, but I added it to keep it consistent with organic_uri decision
luchotc
commented
Apr 20, 2021
| @@ -121,3 +126,9 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
No real benefit here, just to keep the tests less verbose
This was referenced Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
retenantize_infor apps (with real benefits on organic apps), which receives an organization and atenantized_pathand returns that path "retenantized".Introduce
untenantizemethod which receives a path and returns that path without the organization part of the route.I could have implemented without adding a new method, but I needed to keep the other methods that receive a request because it's an interface that's still being used across other apps
Also I'm dropping inorganic_path_for that it is not required anymore