Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test_function_release_strong_count #535

Merged
merged 1 commit into from
Jul 16, 2023
Merged

fix: test_function_release_strong_count #535

merged 1 commit into from
Jul 16, 2023

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Jul 16, 2023

As no strong reference was active anymore, the OS could free the memory, overwriting the original strong count value. Now, we're ensuring that at least one strong reference exists at the end of the test, to avoid memory from being freed

@Wodann Wodann added the type: fix Bug fix or report label Jul 16, 2023
@Wodann Wodann added this to the Mun v0.5.0 milestone Jul 16, 2023
@Wodann Wodann self-assigned this Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #535 (f93d7b1) into main (42fadbd) will increase coverage by 2.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
+ Coverage   84.37%   87.31%   +2.94%     
==========================================
  Files         275      275              
  Lines       31185    31182       -3     
==========================================
+ Hits        26312    27227     +915     
+ Misses       4873     3955     -918     
Impacted Files Coverage Δ
crates/mun_runtime_capi/src/function.rs 99.59% <100.00%> (-0.01%) ⬇️

... and 13 files with indirect coverage changes

@Wodann Wodann marked this pull request as ready for review July 16, 2023 16:41
@Wodann Wodann merged commit ac4b4b5 into main Jul 16, 2023
@Wodann Wodann deleted the fix/strong-count branch July 16, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Bug fix or report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants