Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates test.dart to correctly handle windows paths #1076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tool/bin/test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,14 @@ class Test {

bool parse() {
// Get the path components.
var parts = _path.split("/");
var parts = _path.split(Platform.pathSeparator);
var subpath = "";
String state;

// Figure out the state of the test. We don't break out of this loop because
// we want lines for more specific paths to override more general ones.
for (var part in parts) {
if (part == ".") continue;
if (subpath.isNotEmpty) subpath += "/";
subpath += part;

Expand Down