Improvements to http_response #1239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to using http_responsecode and http_loadtime with the same configuration, this plugin performs only one request per site and munin run to gather its statistics.
- ignore include during shellcheck - check if needed programs are installed - use long argument names for graph_args - remove un-needed empty definitions - improve variable names - validate parameter max_time - update copyright statement - write all configurable arguments into one array - use same check for short_label and follow_redirect - reformat documentation
|
Your changes look good to me, thank you! One of your commits is a merge commit. Could you please get rid of it? Merge commits make it harder to understand the history. Thank you! |
|
Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces various improvement to the http_response plugin: