-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Database fixes #844
base: master
Are you sure you want to change the base?
New Database fixes #844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike this "new" logic.
If the Pak is omitted it means it's not supported. It's easier to just add supported devices and initialize anything else as "No" (Yes | No, True | False, 1 | 0).
I suspect this is the weird statement here. Where the database states a game support Pack accessories when it actually don't? |
As far as I know, the opposite case is more common. Many games can unlock additional functionality with certain Paks, even old ones by omission. Example: If you have Perfect Dark and activate Hi-res with Expansion Pak and then you power off the console and switch to OoT, the PD's anti-aliasing is applied to OoT as well. But OoT hangs if you render certain parts of Hyrule Field. The Hi-res mode can be deactivated from any other game that supports Hi-res. But to apply it to OoT, it only recognizes PD's one. |
It's true that the database doesn't explicitly state that, but...bear with me. For example, this is with current database: I suspect that somehow mupen64plus initializes by default the Rumble Pak and the Controller Pak, unless the relevant keys declare expressly the opposite. I guess this is an intended behavior to enable the two aforementioned accessories for homebrews, hacked roms or just unknown roms. @Jj0YzL5nvJ I think mupen64plus already uses what you propose, just that in this case Rumble Pak and Controller Pak are set on "1". |
If there's no interest in merging this PR then we can close it, although I'd really like to see it being merged instead. |
Since there are a lot of fixes, I thought it's best to make two separate commits for (a bit) easier review.
The first one commit is very large and the reason for this is that currently, according to the database, official and licensed games advertise their support for Pak accessories when they actually don't. For example, Super Mario 64 (U) [!] doesn't support any of available accessories for N64, but here on mupen64plus the game appears to advertise Rumble Pak support, which is false. So, to correct this lie, we must specify also what Paks it doesn't support, and the end result is that for all games we add some thousand of new lines to database.
The second commit just adds new prototypes and betas, and it also specify what Paks they support. There are also minor fixes, correcting good names to reflect more those in No-Intro. I have also moved Japanese OoT entries at the bottom of the list, for which it can make the PR appearing confusing to whose have to review it, and I apologize for that.
I have tested this new version of the database and it hasn't given any errors so far.