Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update errors in multisig contracts #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update errors in multisig contracts #3

wants to merge 1 commit into from

Conversation

rvem
Copy link

@rvem rvem commented Oct 1, 2019

Currently, all contracts use PUSH unit (); FAILWITH in case of
different failures. It would be more convenient to fail with something
more specific. Here we propose failures with human-readable strings.

@rvem
Update errors in multisig contracts
7fd2c84 
Currently all contracts use `PUSH unit (); FAILWITH` in case of
different failures. It would be more convenient to fail with something
more specific. Here we propose failures with human-readable strings.
@gromakovsky
Copy link

Since at least one of these contracts seems to be used by tezos-client, I think it's better to find it in tezos/tezos and make PR there. This one doesn't seem to be likely to reviewed in near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gromakovsky gromakovsky gromakovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvem @gromakovsky