Skip to content

Commit

Permalink
Merge pull request #25912 from rettinghaus/xml/muted
Browse files Browse the repository at this point in the history
Fix #25891: do not write muted strings
  • Loading branch information
miiizen authored Jan 9, 2025
2 parents a3de1a8 + e7b3603 commit a72797e
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8582,13 +8582,13 @@ static void writeMusicXml(const FretDiagram* item, XmlWriter& xml)
}

for (int i = 0; i < item->strings(); ++i) {
int mxmlString = item->strings() - i;
const int mxmlString = item->strings() - i;

std::vector<int> bStarts;
std::vector<int> bEnds;
for (auto const& j : item->barres()) {
FretItem::Barre b = j.second;
int fret = j.first;
const int fret = j.first;
if (!b.exists()) {
continue;
}
Expand All @@ -8609,7 +8609,7 @@ static void writeMusicXml(const FretDiagram* item, XmlWriter& xml)
// Markers may exists alongside with dots
// Write dots
for (auto const& d : item->dot(i)) {
if (!d.exists()) {
if (!d.exists() || d.dtype == FretDotType::CROSS) {
continue;
}
xml.startElement("frame-note");
Expand Down

0 comments on commit a72797e

Please sign in to comment.