Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Home Assistant retry after integration setup fails #71

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Let Home Assistant retry after integration setup fails #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions custom_components/huesyncbox/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import Platform
from homeassistant.core import HomeAssistant
from homeassistant.exceptions import ConfigEntryAuthFailed, ConfigEntryError
from homeassistant.exceptions import ConfigEntryAuthFailed, ConfigEntryNotReady
from homeassistant.helpers import (
entity_registry,
)
Expand Down Expand Up @@ -47,7 +47,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
except aiohuesyncbox.Unauthorized as err:
raise ConfigEntryAuthFailed(err) from err
except aiohuesyncbox.RequestError as err:
raise ConfigEntryError(err) from err
raise ConfigEntryNotReady(err) from err
finally:
if not initialized:
await api.close()
mvdwetering marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ async def test_handle_communication_error_during_setup(hass: HomeAssistant, mock

config_entry = hass.config_entries.async_get_entry(integration.entry.entry_id)
assert config_entry is not None
assert config_entry.state == ConfigEntryState.SETUP_ERROR
assert config_entry.state == ConfigEntryState.SETUP_RETRY

assert mock_api.close.call_count == 1

Expand Down