Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Objects interface - use axis preconfigured label position #3696

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Fix] Objects interface - use axis preconfigured label position #3696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ad63d
Test plotting on secondary axes
MaozGelbart May 20, 2024
f00e31d
Infer label position from target axis
MaozGelbart May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions seaborn/_core/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,8 @@ def _setup_figure(self, p: Plot, common: PlotData, layers: list[Layer]) -> None:
# axis / tick labels can be shown on interior shared axes if desired

axis_obj = getattr(ax, f"{axis}axis")
visible_side = {"x": "bottom", "y": "left"}.get(axis)
# This allows correct handling for twin{x/y} axises (GH 3614)
visible_side = axis_obj.get_label_position()
show_axis_label = (
sub[visible_side]
or not p._pair_spec.get("cross", True)
Expand All @@ -1172,8 +1173,9 @@ def _setup_figure(self, p: Plot, common: PlotData, layers: list[Layer]) -> None:
)
)
for group in ("major", "minor"):
side = {"x": "bottom", "y": "left"}[axis]
axis_obj.set_tick_params(**{f"label{side}": show_tick_labels})
axis_obj.set_tick_params(
**{f"label{visible_side}": show_tick_labels}
)
for t in getattr(axis_obj, f"get_{group}ticklabels")():
t.set_visible(show_tick_labels)

Expand Down
18 changes: 18 additions & 0 deletions tests/_core/test_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,6 +1124,24 @@ def test_on_axes(self):
p = Plot([1], [2]).on(ax).add(m).plot()
assert m.passed_axes == [ax]
assert p._figure is ax.figure
assert ax.yaxis.get_label_position() == "left"
assert ax.yaxis.get_ticks_position() == "left"
assert ax.xaxis.get_label_position() == "bottom"
assert ax.xaxis.get_ticks_position() == "bottom"

@pytest.mark.parametrize("axis,exp_position", [("x", "top"), ("y", "right")])
def test_on_secondary_axes(self, axis, exp_position):

ax = mpl.figure.Figure().subplots()
twinned_ax = {"x": "y", "y": "x"}[axis]
ax2 = getattr(ax, f"twin{twinned_ax}")()
m = MockMark()
p = Plot([1], [2]).on(ax2).add(m).plot()
assert m.passed_axes == [ax2]
assert p._figure is ax2.figure
targetaxis = getattr(ax2, f"{axis}axis")
assert targetaxis.get_label_position() == exp_position
assert targetaxis.get_ticks_position() == exp_position

@pytest.mark.parametrize("facet", [True, False])
def test_on_figure(self, facet):
Expand Down
Loading