-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering for center packet loss #123
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 908 918 +10
=========================================
+ Hits 908 918 +10 ☔ View full report in Codecov by Sentry. |
18cd3c2
to
891ba7f
Compare
d14b17d
to
f40ee33
Compare
Negative |
d9d7dd2
to
5d2a49c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PyxieLouStar I looked at the changes and they look very straight-forward. The unit tests make sense.
I may revisit this code later since these if statements can technically be taken out of the loop (the answer is the same in every iteration of the loop so you can just precompute which branch to go down for each shape). I imagine this is a teeny tiny effect that will save us microseconds per obs so I'm just going to approve/merge.
Provide the option for flagging shapes only if the computed significance value is negative.
Description
Certain effects, such as correlator packet loss, show up as a negative in the SSINS. This change allows users to set the
sig_thresh
value for any shape as a negative number in order to have the shape only be flagged when the significance is negative. The behavior for positivesig_thresh
is unchanged: the absolute value of the significance will be used when checking for the shape.Checklist:
Main Code Body Checklist:
Scripts Checklist: