Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a SSINS test for future pyuvdata compatibility #125

Merged
merged 4 commits into from
May 14, 2024

Conversation

bhazelton
Copy link
Collaborator

@bhazelton bhazelton commented May 1, 2024

Description

This fixes several things that will break for pyuvdata>=v3.0, including going to future shapes always.

I made some minor tweaks to the GitHub actions yaml to speed up CI.

Checklist:

Main Code Body Checklist:

  • Add or update docstring related to code change
  • Add a unit test that verifies the efficacy of the code
  • Write a tutorial if the feature would be useful to others to use
  • Update CHANGELOG.md

Scripts Checklist:

  • Add useful help strings for any arguments that are parsed
  • Manually check that the script runs and gives proper results
  • Update CHANGELOG.md

@mwilensky768
Copy link
Owner

Thanks @bhazelton . Other than random fails due to something with setuptools_scm (tersely documented in #126), this is passing and looks good. Will merge when the ubuntu builds finish.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8991688) to head (e76e44e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          918       918           
=========================================
  Hits           918       918           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwilensky768
Copy link
Owner

Thanks for the futureproofing! This is so so helpful. I'm going to merge now.

@mwilensky768 mwilensky768 merged commit ef4ebc3 into mwilensky768:master May 14, 2024
13 checks passed
@bhazelton bhazelton deleted the future_pyuvdata_fix branch May 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants