Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMP, can't remember if i tested bands_wt_all #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sthartman
Copy link

Here's the OpenMP parallelization. I also deleted a few variables which were declared but not used. I don't remember the exact reason for changing the error code in the READ statements, but for some reason I had to do that to make it work - I think it's because it called a subroutine with a static variable. In general I recall that I had trouble with READ operations, I believe it uses some kind of buffer that's shared between the threads so it's not very thread-safe.

I would suggest testing the bands_wt_all if you have the input files on hand to do it, I don't remember if I tested that one myself. It might need an OMP_CRITICAL like the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant