-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring usermanager.py #1461
base: develop
Are you sure you want to change the base?
Refactoring usermanager.py #1461
Conversation
Is this a draft pr, and what is it meant do do ? |
its initial purpose was a bit different that's where the branch name came from |
I see, Ill put this as draft for the moment |
as you wish, but I think I have no more changes for this PR, this is final version from my side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think it can be merged.
@marcus-oscarsson I am not sure what led you to believe it might still be a draft. Probably because @dominikatrojanowska did not write a description on the pull request.
Looks to me like there are no logical changes, but it is adding type hints, docstrings, and refactoring.
@dominikatrojanowska, how would you like to proceed. I can propose to try to carry over some of this work to a new PR (relatively soon) or you can try to resolve the conflicts. Let me know :) |
Adding type hints, docstrings, and refactoring usermanage.py