removing system log #1468
Merged
removing system log #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walesch-yan
commented
Oct 24, 2024
Comment on lines
-29
to
-30
| "logger": record.name, | ||
| "stack_trace": stack_trace, |
There was a problem hiding this comment.
I removed the logger and stack_trace from the LoggingHandler, as we only need the user_level_log to be shown in the UI and due to some concerns about the stack_trace being sent to the front-end in #1393. Could this removal be confirmed as accepted or is the general opinion to keep it?
|
Wonderful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the System log from the UI as discussed in #1405 including actions and state variables related to it.
While at it I modified the
MX3LoggingHandler, so that only records from theuser-level-logare kept in the front-end part.