Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MTStatusBarOverlay with support for UIStatusBarStyleBlackTranslucent (including progress), user interaction in history, the ability to remove items from history, and an example app to demonstrate these new features. #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rileytestut
Copy link

Includes the same features from my previous pull request, but this is a modified version of a much more recent commit. Took a long time to finally implement, and I suggest you do some more compatibility testing. I've tested it using the example app and everything works fine, but as there a lot of changes you can never be too careful.

Hopefully you and everyone else finds this useful :)

…s), user interaction in history, the ability to remove items from history, and an example app to demonstrate these new features.
@myell0w
Copy link
Owner

myell0w commented May 20, 2012

Wow, thank you for your work and the amount of changes. I did at quick test and it looks very good overall, but I found a few bugs, so I'm afraid it will take me quite some time to do a detailed review and merge this in (probably partly), but I will do - hopefully soon! I can see what you're trying to achieve with the parameter "key", but I don't like that it complicates the API so I think I won't merge this part, but rather use the message itself as the key. That's not 100 % unique and there might be situations where this is a problem, but I still prefer it over the complicated API. Maybe I will find an elegant way to offer at least a solution to specify a custom key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants