fix(prestashop): display full url on start and untangle env vars

myparcelnl · Sep 19, 2024 · ea1da6b · ea1da6b
1 parent f22a0b1
commit ea1da6b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/images/prestashop/Dockerfile b/images/prestashop/Dockerfile
@@ -96,17 +96,18 @@ COPY ./config/php-fpm /usr/local/etc/php-fpm.d
 COPY ./config/php     /usr/local/etc/php
 COPY ./scripts/       /tmp/scripts
 
+ENV PHP_VERSION=${PHP_VERSION}
 ENV PS_VERSION=${PS_VERSION}
 
-ENV ROOT_DIR=${ROOT_DIR}
-
-
 ###
 # Core
 ###
 ENV BASE_URL=prestashop.dev.myparcel.nl
 ENV FULL_URL=https://${BASE_URL}
-ENV ROOT_DIR=/var/www/html
+ENV ROOT_DIR=${ROOT_DIR}
+
+ENV TMP_MODULES_DIR="/tmp/modules"
+ENV PS_MODULES_DIR="$ROOT_DIR/modules"
 
 ###
 # Database
@@ -133,7 +134,7 @@ ENV PS_FOLDER_ADMIN=admin1
 
 # Admin credentials
 ENV PS_ADMIN_MAIL=admin@${BASE_URL}
-ENV PS_ADMIN_PASSWORD=admin
+ENV PS_ADMIN_PASSWORD=admin123!
 
 
 ###

diff --git a/images/prestashop/scripts/entrypoint.sh b/images/prestashop/scripts/entrypoint.sh
@@ -1,8 +1,5 @@
 #!/bin/bash
 
-export TMP_MODULES_DIR="/tmp/modules"
-export PS_MODULES_DIR="$ROOT_DIR/modules"
-
 for script in /tmp/scripts/_*; do source $script; done
 
 # Start php fpm in the background in advance.
@@ -18,7 +15,6 @@ warmup-cache
 
 reset-permissions
 
-tail-logs
-
 h1 "🐧 PrestaShop is ready at ${FULL_URL} ✨"
-sleep infinity
+
+tail-logs