Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed external config max versions deletion #205

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fixed external config max versions deletion #205

merged 3 commits into from
Oct 23, 2024

Conversation

Ismail731404
Copy link
Member

No description provided.

@Ismail731404 Ismail731404 self-assigned this Oct 22, 2024
@SchawnnDev SchawnnDev changed the title Refactor the way of creating request for division into two parts Fixed external config max configs deletion Oct 23, 2024
@SchawnnDev SchawnnDev changed the title Fixed external config max configs deletion Fixed external config max versions deletion Oct 23, 2024
@github-actions GitHub Actions
Copy link

Go test coverage: 11.6% for commit 1099b67
⚠️ 23 of 51 packages have zero coverage.
  • github.com/myrteametrics/myrtea-engine-api/v5
  • github.com/myrteametrics/myrtea-engine-api/v5/docs
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/app
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/config/connectorconfig
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/config/esconfig
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/config/externalconfig
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/connector
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/coordinator
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/evaluator
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/action
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/draft
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/issues
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/rootcause
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/metrics
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/router
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/router/oidc
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/rule
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/search
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/security/roles
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/security/users
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/variablesconfig
  • github.com/myrteametrics/myrtea-engine-api/v5/plugins/baseline
View coverage for all packages 
# Package Name                                                                   | Coverage
- github.com/myrteametrics/myrtea-engine-api/v5                                  |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/docs                             |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/app                    |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/calendar               |    29.2%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/config/connectorconfig |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/config/esconfig        |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/config/externalconfig  |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/connector              |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/coordinator            |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/email                  |    72.4%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/evaluator              |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer              |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/action       |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/draft        |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/issues       |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/rootcause    |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/export                 |    60.7%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/fact                   |    53.8%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/fact/lexer             |   100.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/handlers               |     3.8%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/handlers/render        |     9.8%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/history                |     2.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/ingester               |    10.8%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/metrics                |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/modeler                |    27.7%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/models                 |     4.5%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/notifier               |    36.4%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/notifier/notification  |    33.5%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/processor              |    36.6%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/reader                 |     8.5%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/router                 |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/router/auth            |    75.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/router/oidc            |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/rule                   |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/scheduler              |     6.2%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/search                 |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/security/permissions   |    30.3%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/security/roles         |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/security/users         |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/service                |    73.9%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/situation              |     6.5%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/tasker                 |    14.8%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/tests                  |    36.6%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/utils                  |   100.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/utils/queryutils       |    77.8%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/variablesconfig        |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/plugins                          |    57.9%
- github.com/myrteametrics/myrtea-engine-api/v5/plugins/baseline                 |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/plugins/baseline/proto           |     5.4%
+ github.com/myrteametrics/myrtea-engine-api/v5/plugins/pluginutils              |     4.3%
+ github.com/myrteametrics/myrtea-engine-api/v5/plugins/standalone               |     8.9%

@Ismail731404 Ismail731404 merged commit 70dba8a into master Oct 23, 2024
1 check passed
@Ismail731404 Ismail731404 deleted the fix/modify-request-creation-split branch October 23, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchawnnDev SchawnnDev SchawnnDev approved these changes

@cedricablain cedricablain Awaiting requested review from cedricablain cedricablain is a code owner

Assignees

@Ismail731404 Ismail731404

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ismail731404 @SchawnnDev