Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Request Class memory allocation #225

Merged
merged 3 commits into from
Oct 1, 2017
Merged

Correct Request Class memory allocation #225

merged 3 commits into from
Oct 1, 2017

Conversation

Akubi
Copy link
Contributor

@Akubi Akubi commented Oct 1, 2017

Change « Request Class » memory allocation, issue #214

  • Add buffer « char _value[MAX_PAYLOAD+1] » to keep request data
  • Buffer size is to prevent buffer overrun

@Akubi
Copy link
Contributor Author

Akubi commented Oct 1, 2017

Replace PR #217
This PR only address issue #214

@Akubi Akubi mentioned this pull request Oct 1, 2017
Closed
@user2684 user2684 changed the title Correct Reqest Class memory allocation Correct Request Class memory allocation Oct 1, 2017
@user2684 user2684 merged commit ed46f77 into mysensors:development Oct 1, 2017
@user2684
Copy link
Contributor

user2684 commented Oct 1, 2017

Merged, thanks a lot!

@Akubi Akubi deleted the RequestClassMemoryAllocation branch October 1, 2017 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akubi @user2684