[Surrey] Don’t pass blank updates to Boomi

mysociety · Sep 20, 2024 · 36e192c · 36e192c
1 parent d8cfef2
commit 36e192c
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/perllib/Open311/Endpoint/Integration/Boomi.pm b/perllib/Open311/Endpoint/Integration/Boomi.pm
@@ -294,7 +294,11 @@ sub post_service_request_update {
     my $hash = substr(md5_hex(join('', @parts)), 0, 8);
     my $update_id = $args->{service_request_id} . "_" . $hash;
 
-    my $service_request_id = $self->boomi->upsertHighwaysTicket($ticket);
+    if ($args->{description}) {
+        # State changes on FMS may create updates with empty descriptions, which
+        # we don't want to send to Boomi as it will return an error.
+        my $service_request_id = $self->boomi->upsertHighwaysTicket($ticket);
+    }
 
     return Open311::Endpoint::Service::Request::Update::mySociety->new(
         service_request_id => $args->{service_request_id},

diff --git a/t/open311/endpoint/surrey_boomi.t b/t/open311/endpoint/surrey_boomi.t
@@ -38,6 +38,8 @@ $lwp->mock(request => sub {
                     ]
                 };
                 return HTTP::Response->new(200, 'OK', [], encode_json({"ticket" => { system => "Zendesk", id => 123457 }}));
+            } elsif ($content && !$content->{comments}->[0]->{body}) {
+                return HTTP::Response->new(400, 'Bad request', [], "Bad request");
             } else {
                 is_deeply $content, {
                     "comments" => [
@@ -454,6 +456,30 @@ subtest "POST Service Request Update with photo" => sub {
     restore_time();
 };
 
+subtest "POST Service Request Update with blank description" => sub {
+    set_fixed_time('2023-05-01T12:00:00Z');
+
+    my $res = $surrey_endpoint->run_test_request(
+        POST => '/servicerequestupdates.json',
+        jurisdiction_id => 'surrey_boomi',
+        api_key => 'api-key',
+        updated_datetime => '2023-05-02T12:43:00Z',
+        service_request_id => 'Zendesk_123458',
+        status => 'FIXED',
+        description => '',
+        last_name => "Smith",
+        first_name => "John",
+        update_id => '10000002',
+    );
+    is $res->code, 200;
+    is_deeply decode_json($res->content),
+        [ {
+            'update_id' => "Zendesk_123458_830d4308",
+        } ], 'correct json returned';
+
+    restore_time();
+};
+
 subtest "GET Service Requests" => sub {
     my $res = $surrey_endpoint->run_test_request(
         GET => '/requests.json?jurisdiction_id=surrey_boomi&api_key=api-key&start_date=2024-05-01T09:00:00Z&end_date=2024-05-01T10:00:00Z',