[Northumberland] Fetch extra_details from Alloy

mysociety · Sep 4, 2024 · 93c66a8 · 93c66a8
1 parent 838bdae
commit 93c66a8
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 2 deletions.
diff --git a/perllib/Open311/Endpoint/Integration/AlloyV2.pm b/perllib/Open311/Endpoint/Integration/AlloyV2.pm
@@ -651,6 +651,10 @@ sub _get_inspection_updates {
                 $args{extras} = $assigned_to_user if $assigned_to_user;
             }
 
+            my $detailed_information
+                = $attributes->{ $mapping->{extra_details} } // '';
+            $args{extras}{detailed_information} = $detailed_information;
+
             push @updates, Open311::Endpoint::Service::Request::Update::mySociety->new( %args );
         }
     }

diff --git a/t/open311/endpoint/json/alloyv2/northumberland/customer_requests_query_response.json b/t/open311/endpoint/json/alloyv2/northumberland/customer_requests_query_response.json
@@ -74,6 +74,10 @@
           "attributeCode": "attributes_customerRequestEmail_63868f209e005f0396e519ca",
           "value": "[email protected]"
         },
+        {
+          "attributeCode": "attributes_customerRequestFMSExtraDetails_646e07533726d8036a7a4022",
+          "value": "Goodbye here"
+        },
         {
           "attributeCode": "attributes_customerRequestAssignedTo_653664b0557119eef53a97e1",
           "value": [

diff --git a/t/open311/endpoint/json/alloyv2/northumberland/reconstruct_123456_20231113110500.json b/t/open311/endpoint/json/alloyv2/northumberland/reconstruct_123456_20231113110500.json
@@ -33,6 +33,10 @@
         "attributeCode": "attributes_customerRequestEmail_63868f209e005f0396e519ca",
         "value": "[email protected]"
       },
+      {
+        "attributeCode": "attributes_customerRequestFMSExtraDetails_646e07533726d8036a7a4022",
+        "value": "Hello there"
+      },
       {
         "attributeCode": "attributes_customerRequestAssignedTo_653664b0557119eef53a97e1",
         "value": [

diff --git a/t/open311/endpoint/northumberland_alloy.t b/t/open311/endpoint/northumberland_alloy.t
@@ -403,8 +403,9 @@ subtest "check fetch updates" => sub {
             update_id          => '100001',
             updated_datetime   => '2023-11-13T11:05:00Z',
             extras             => {
-                assigned_user_name  => 'FMS User 123',
-                assigned_user_email => '[email protected]',
+                assigned_user_name   => 'FMS User 123',
+                assigned_user_email  => '[email protected]',
+                detailed_information => 'Hello there',
             },
         },
         {   description        => '',
@@ -416,6 +417,7 @@ subtest "check fetch updates" => sub {
             extras             => {
                 assigned_user_name  => 'FMS User 234',
                 assigned_user_email => '[email protected]',
+                detailed_information => '',
             },
         },
         {   description        => '',
@@ -427,6 +429,7 @@ subtest "check fetch updates" => sub {
             extras             => {
                 assigned_user_name  => 'FMS User 345',
                 assigned_user_email => '[email protected]',
+                detailed_information => '',
             },
         },
     ], 'correct json returned';

diff --git a/t/open311/endpoint/northumberland_alloy.yml b/t/open311/endpoint/northumberland_alloy.yml
@@ -168,6 +168,7 @@
     "updates": "attributes_customerRequestFMSUpdates_6387cc9805cb250393e00e2f",
     "status": "attributes_customerRequestMainFMSStatus_63fcb297c9ec9c036ec35dfb",
     "inspector_comments": "attributes_customerRequestInspectorsComments_638629fcfb3d97038c4e5d5a",
+    "extra_details": "attributes_customerRequestFMSExtraDetails_646e07533726d8036a7a4022",
     "assigned_to_user": "attributes_customerRequestAssignedTo_653664b0557119eef53a97e1",
   },