Improve codespace secrets approach #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
master
branch
3 times, most recently
from
2c2b1cc
to
ccc444c
Compare
dracos
requested changes
Sep 6, 2024
docker-compose.yml
Outdated
| MAPIT_URL: ${MAPIT_URL:-https://mapit.mysociety.org/} | ||
| MAPIT_API_KEY: ${MAPIT_API_KEY:-} | ||
| DEMOCRACYCLUB_TOKEN: ${DEMOCRACYCLUB_TOKEN:-} | ||
| RECAPACHA_SITE_KEY: ${RECAPACHA_SITE_KEY:-} |
dracos
requested changes
Oct 4, 2024
.devcontainer/devcontainer.json
Outdated
| "DEMOCRACYCLUB_TOKEN": { | ||
| "description": "API key for the Democracy Club API - only for election postcode lookups." | ||
| }, | ||
| "RECAPACHA_SITE_KEY": { |
docker-compose.yml
Outdated
| MAPIT_URL: ${MAPIT_URL:-https://mapit.mysociety.org/} | ||
| MAPIT_API_KEY: ${MAPIT_API_KEY:-} | ||
| DEMOCRACYCLUB_TOKEN: ${DEMOCRACYCLUB_TOKEN:-} | ||
| RECAPACHA_SITE_KEY: ${RECAPACHA_SITE_KEY:-} |
|
Sorry sorry - should all be fixed. |
dracos
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features like the donate page and election lookup need external API keys, which doesn't work nicely with the docker setup because the conf/general is recreated each time the docker is opened (rather than created).
This PR:
conf/generalfile.