Improved day links accessibility for calendar component #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascumsille
force-pushed
the
1833-calendar-links
branch
from
5ce0b5c
to
799a421
Compare
|
Good fix - but I think this specific blue looks like a "you have selected the following date range". A lighter one maybe (example below, but that then has problems with the white text...)? Otherwise seems fine.
|
|
@ajparsons I was hoping the space would be enough to make obvious that is not a range, but it didn't work. Instead of going for adding background, I went for text-decoration + font-weight to make it pop up more. I think now they are quite noticeable a link. I added some off-set for the underline so the numbers are easier to read as well. Let me know what you think. |
|
@ajparsons I updated the video at the top. |
ajparsons
approved these changes
Oct 15, 2024
lucascumsille
force-pushed
the
1833-calendar-links
branch
from
221986e
to
1a8f8e5
Compare
lucascumsille
force-pushed
the
1833-calendar-links
branch
from
1a8f8e5
to
bb7ea42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1833
Screen.Recording.2024-10-15.at.07.21.06.mov
Just in case the "Green one" is the active day