Committee notifier #54
Conversation
Creates the ATCDocument model, which is largely identical to the Source model.
Scrapes ATC documents and detects announcements of changes to committee membership.
| self.stdout.write('ATC documents found: %d\nATC documents created: %d\n' % ( | ||
| sources_count, created_count)) | ||
|
|
||
| def retrieve_sources(self, start, options): |
There was a problem hiding this comment.
I think it would be worth factoring out retrieve_sources into a mixin, since it's almost exactly the same in za_hansard_check_for_new_sources, it'd just need the following additional parameters, I think:
- The category ID for
url - the source model class (either
ATCDocumentorSource) - the limit
Also, I think it would be worth replacing the recursion of that method with a loop - it doesn't seem worth adding to the stack for each new document.
|
Hi @geoffkilpin - sorry for not dealing with this for so long, please hassle me if a pull request hasn't been reviewed within a couple of days! I've left a few comments, the only really significant one is a suggestion to factor out the duplicate code in |
|
Hi @geoffkilpin, @mhl - I would recommend using flake8 https://pypi.python.org/pypi/flake8 to check for PEP8 type things. PyLint has so much to say it's hard to find the useful bits... |
Creates a scraper for Parliament's Announcements, Tablings and Committee Reports documents and searches these for announcements of changes to committee membership. If an announcement is found, an email is sent to an address specified in the Pombola configuration file (see mysociety/pombola#1488)