Fix source fetching #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easier to see what's gone wrong if you can see a stacktrack. This also means that if the management command fails in this method then it will exit with a non-zero status, which will trigger cron error emails which we want.
- Remove commented code that doesn't seem useful - Remove useless comment
Newer documents use a UUID as their document number, aka ID, so switch this field to be a char so we can store everything.
There is now a JSON feed of sources, so we can drastically simplify this code and remove a few options while we're at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parliament website has been updated so we need to update the scraper for retrieving sources. Luckily the new page uses AJAX calls to a JSON API, so we can get the data we need directly from the JSON rather than scraping HTML. This has drastically simplified the source fetching script, and I've taken the opportunity to clean things up a bit while I was in there.
Part of mysociety/pombola#2458