This repository has been archived by the owner on Jan 25, 2019. It is now read-only.
Enhance Travis-CI to optionally compare Wok output #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matt-garman
commented
Dec 16, 2015
matt-garman
commented
- Add file "test_site/wok_expected_output-test_site" which is the output of "wok -v" when run with current upstream master.
- Introduce new environment variable "CMP_OUTPUT" in .travis.yml.
- Enhance bin/site-tests such that if CMP_OUTPUT==true, it will run cmp on the wok_expected_output-$TEST_SITE file versus the output of the "wok -v" run.
- Goal of this enhancement is to support more robust testing of fixes for issues reStructuredText rendering errors don't show filename, just "string" #144 and reStructuredText rendering errors have incorrect line numbers #145.
render() definitions so it can be passed through to the actual RST docutils renderer. This code fails on the test site, and has some debug print statements added. It is intended as an illustration only, definitely not production quality.
* libsass is faster as it is written in C * Drop Ruby dependency * Add Sass to the test site * Use libsass-python API to compile Sass files * Remove .sass/.scss files from output_dir after compilation
…patterns that will be ignored when processing the tree
…skip over files matching glob patterns in the specified list
* libsass is faster as it is written in C * Drop Ruby dependency * Add Sass to the test site * Use libsass-python API to compile Sass files * Remove .sass/.scss files from output_dir after compilation
* libsass is faster as it is written in C * Drop Ruby dependency * Add Sass to the test site * Use libsass-python API to compile Sass files * Remove .sass/.scss files from output_dir after compilation
- Add file "test_site/wok_expected_output-test_site" which is the output of "wok -v" when run with current upstream master. - Introduce new environment variable "CMP_OUTPUT" in .travis.yml. - Enhance bin/site-tests such that if CMP_OUTPUT==true, it will run cmp on the wok_expected_output-$TEST_SITE file versus the output of the "wok -v" run. - Goal of this enhancement is to support more robust testing of fixes for issues mythmon#144 and mythmon#145.
This was a known-bad commit just to illustrate a problem. A bad way to fix issue mythmon#144 (add source_path param to all render() methods in wok/renderers.py). Removing to clean up. This reverts commit 7cf34e2.
This reverts commit 50d0430.
Remove a line from test_site/wok_expected_output-test_site that caused the Travis-CI job to fail on upstream during pull request.
|
On the one hand, it's sad that we have expected errors/warnings. On the other, it'll be good to note any changes and keep the tests up to date. @mythmon, any objections to merging this? |
|
@matt-garman, thank you for the work and sorry for the delay in getting back to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.