This repository has been archived by the owner on Jan 25, 2019. It is now read-only.
Issue 144 rst source path take2 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version is 0.13.1)
The reStructuredText render will pass use this metadata if availbe, and pass through to the source_path parameter in publich_parts. This is to fix issue mythmon#144.
docutils.core.publish_parts() source_path parameter. This is to fix issue mythmon#144.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR broke the previous attempt at fixing issue #144. Looks like now we are now passing page.meta to the render() function. wok/page.py line 120 has comment, "the page.meta might contain renderer options". So I added a new metadata field, "source_file". This value is the input source file name.
For the reStructuredText render, page_meta['source_path'] will be passed to docutils.core.publish_parts().
This allows the source filename to be printed if the renderer encounters an error.