Fix a NPE issue in GpuRand (NVIDIA#11647)

curXORShiftRandomSeed is marked as transient, so it will be null on executors without retry-restore context, leading to this NPE. This fix removes the transient for curXORShiftRandomSeed, seed and previousPartition that will be used by the computation on executors. Signed-off-by: Firestarman <[email protected]>
mythrocks · Oct 28, 2024 · b653ce2 · b653ce2
1 parent 91db040
commit b653ce2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...rc/main/scala/org/apache/spark/sql/rapids/catalyst/expressions/GpuRandomExpressions.scala b/...rc/main/scala/org/apache/spark/sql/rapids/catalyst/expressions/GpuRandomExpressions.scala
@@ -49,16 +49,16 @@ case class GpuRand(child: Expression) extends ShimUnaryExpression with GpuExpres
    */
   @transient protected var rng: RapidsXORShiftRandom = _
 
-  @transient protected lazy val seed: Long = child match {
+  private lazy val seed: Long = child match {
     case GpuLiteral(s, IntegerType) => s.asInstanceOf[Int]
     case GpuLiteral(s, LongType) => s.asInstanceOf[Long]
     case _ => throw new RapidsAnalysisException(
       s"Input argument to $prettyName must be an integer, long or null literal.")
   }
 
-  @transient protected var previousPartition: Int = 0
+  private var previousPartition: Int = 0
 
-  @transient protected var curXORShiftRandomSeed: Option[Long] = None
+  private var curXORShiftRandomSeed: Option[Long] = None
 
   private def wasInitialized: Boolean = rng != null