lints: use [workspace.lints]

Depends on a newly stabilized feature which will be in 1.75 and available on nightly today rust-lang/cargo#12115 (comment)
n0-computer · Oct 26, 2023 · d6cb289 · d6cb289
1 parent 401cc6b
commit d6cb289
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 2 deletions.
diff --git a/.cargo/config.toml b/.cargo/config.toml
@@ -1,2 +1,2 @@
 [build]
-rustflags = ["-Wmissing_debug_implementations", "-Wclippy::unused-async"]
+rustflags = []
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -272,7 +272,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@master
-    - uses: dtolnay/rust-toolchain@stable
+    # Can be switched back once 1.75 lands
+    # https://github.com/rust-lang/cargo/issues/12115#issuecomment-1768170381
+    - uses: dtolnay/rust-toolchain@nightly
       with:
           components: clippy
 

diff --git a/Cargo.toml b/Cargo.toml
@@ -22,3 +22,10 @@ debug-assertions = false
 opt-level = 3
 panic = 'abort'
 incremental = false
+
+
+[workspace.lints.rust]
+missing_debug_implementations = "warn"
+
+[workspace.lints.clippy]
+unused-async = "warn"
diff --git a/iroh-bytes/Cargo.toml b/iroh-bytes/Cargo.toml
@@ -11,6 +11,9 @@ repository = "https://github.com/n0-computer/iroh"
 # Sadly this also needs to be updated in .github/workflows/ci.yml
 rust-version = "1.72"
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow = { version = "1", features = ["backtrace"] }
 bao-tree = { version = "0.9.1", features = ["tokio_fsm"], default-features = false }

diff --git a/iroh-gossip/Cargo.toml b/iroh-gossip/Cargo.toml
@@ -11,6 +11,9 @@ repository = "https://github.com/n0-computer/iroh-sync"
 # Sadly this also needs to be updated in .github/workflows/ci.yml
 rust-version = "1.72"
 
+[lints]
+workspace = true
+
 [dependencies]
 # proto dependencies (required)
 anyhow = { version = "1", features = ["backtrace"] }

diff --git a/iroh-metrics/Cargo.toml b/iroh-metrics/Cargo.toml
@@ -11,6 +11,9 @@ repository = "https://github.com/n0-computer/iroh"
 # Sadly this also needs to be updated in .github/workflows/ci.yml
 rust-version = "1.72"
 
+[lints]
+workspace = true
+
 [dependencies]
 prometheus-client = { version = "0.21.0", optional = true }
 once_cell = "1.17.0"

diff --git a/iroh-net/Cargo.toml b/iroh-net/Cargo.toml
@@ -11,6 +11,9 @@ repository = "https://github.com/n0-computer/iroh"
 # Sadly this also needs to be updated in .github/workflows/ci.yml
 rust-version = "1.72"
 
+[lints]
+workspace = true
+
 [dependencies]
 aead = { version = "0.5.2", features = ["bytes"] }
 anyhow = { version = "1", features = ["backtrace"] }

diff --git a/iroh-sync/Cargo.toml b/iroh-sync/Cargo.toml
@@ -11,6 +11,9 @@ repository = "https://github.com/n0-computer/iroh"
 # Sadly this also needs to be updated in .github/workflows/ci.yml
 rust-version = "1.72"
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow = "1"
 blake3 = { package = "iroh-blake3", version = "1.4.3"}

diff --git a/iroh-test/Cargo.toml b/iroh-test/Cargo.toml
@@ -12,6 +12,9 @@ publish = true
 # Sadly this also needs to be updated in .github/workflows/ci.yml
 rust-version = "1.72"
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow = "1"
 tokio = { version = "1", features = ["full"] }

diff --git a/iroh/Cargo.toml b/iroh/Cargo.toml
@@ -12,6 +12,9 @@ default-run = "iroh"
 # Sadly this also needs to be updated in .github/workflows/ci.yml
 rust-version = "1.72"
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow = { version = "1", features = ["backtrace"] }
 bao-tree = { version = "0.9.1", features = ["tokio_fsm"], default-features = false }