Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove direct rustls dependency #94

Merged
merged 1 commit into from
Sep 4, 2024
Merged

deps: Remove direct rustls dependency #94

merged 1 commit into from
Sep 4, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Aug 29, 2024

Quinn now re-exports the correct version of rustls that should be used with it. Let's depend on that instead of having to manually keep the dependency in sync.

Quinn now re-exports the correct version of rustls that should be used
with it.  Let's depend on that instead of having to manually keep
the dependency in sync.
@flub flub requested a review from rklaehn August 29, 2024 14:46
Copy link
Collaborator

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

Did we do this reexport, or is it from upstream quinn?

@rklaehn rklaehn merged commit fe08b15 into main Sep 4, 2024
15 checks passed
@rklaehn rklaehn deleted the flub/no-rustls branch September 4, 2024 07:21
@flub
Copy link
Contributor Author

flub commented Sep 5, 2024

Did we do this reexport, or is it from upstream quinn?

Upstream Quinn did this, it seems like a good idea to me given how tightly coupled it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants