Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin install linux #5

Draft
wants to merge 74 commits into
base: nagilson-admin-install
Choose a base branch
from

Commits on May 18, 2023

  1. Configuration menu
    Copy the full SHA
    005f6ee View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. refactor most of the global sdk code to allow linux to be separated i…

    …nto a distro specific interface
    nagilson committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ba19214 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Configuration menu
    Copy the full SHA
    4a5e04b View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Remove failure test because I couldn't get the test runner to not sho…

    …w a 'failure' on the test even if the exception is caught and expected in an assert
    nagilson committed May 30, 2023
    Configuration menu
    Copy the full SHA
    1735ada View commit details
    Browse the repository at this point in the history
  2. Port the documentation change stating how to test only a subset of fe…

    …atures from the command line
    nagilson committed May 30, 2023
    Configuration menu
    Copy the full SHA
    b80a075 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. rename listSDKS and listRuntimes to listNewestSDKs and listNewestRunt…

    …imes to properly reflect what the command does better
    nagilson committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0f07e17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ec2149 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfa6b32 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2a1cb21 View commit details
    Browse the repository at this point in the history
  5. Update gitignore to ignore .d.ts and .js.map and .js files as they ca…

    …n be created on build and are bloat
    nagilson committed May 31, 2023
    Configuration menu
    Copy the full SHA
    97f20d0 View commit details
    Browse the repository at this point in the history
  6. rename commands to listNewestDotnets -> this is because the command l…

    …ets you pick either runtimes or SDKs, so the old name was technically incorrect even though it was less verbose
    nagilson committed May 31, 2023
    Configuration menu
    Copy the full SHA
    dbf4f81 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8dfb8fd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    42624f4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2e57ddc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a9834cb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    80989e6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0a9c97d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4f30e1d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    cc22387 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Configuration menu
    Copy the full SHA
    19ced1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    541e652 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef7a840 View commit details
    Browse the repository at this point in the history
  4. respond to all pr feedback

    nagilson committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    fba7914 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b4e01de View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    66c1f22 View commit details
    Browse the repository at this point in the history
  7. fix lint issues

    nagilson committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    575e4e4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2360346 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7677214 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. remove unneeded includes

    nagilson committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    724933f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49b6c7d View commit details
    Browse the repository at this point in the history
  3. remove the releases class as we can replace it with the external faci…

    …ng idotnetversion and add the new recommendedVersion command
    nagilson committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    9cdd7f9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6fff95b View commit details
    Browse the repository at this point in the history
  5. respond to lint

    nagilson committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    df82241 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    e84dfbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d917d4 View commit details
    Browse the repository at this point in the history
  3. Merge pull request dotnet#791 from nagilson/nagilson-list-sdks

    Add API Surface to get newest available runtimes + SDKs
    nagilson authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    efcba6b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc30ae9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5f9207e View commit details
    Browse the repository at this point in the history
  6. Remove ignored files

    nagilson committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f777259 View commit details
    Browse the repository at this point in the history
  7. Revert "Remove ignored files"

    This reverts commit f777259.
    nagilson committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    cb86525 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5aeea5e View commit details
    Browse the repository at this point in the history
  9. bump vscode to support activation event removal and temporarily comme…

    …nt out older tests for sdk extension
    nagilson committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    3dbed2d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Configuration menu
    Copy the full SHA
    0f73e30 View commit details
    Browse the repository at this point in the history
  2. add back the support status enum because it separates the logic out f…

    …rom the distro support status api
    nagilson committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4d5f8e2 View commit details
    Browse the repository at this point in the history
  3. Move to linux line endings

    root authored and nagilson committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a144d7c View commit details
    Browse the repository at this point in the history
  4. Get distro detection to work

    root authored and nagilson committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f06f27a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Add logic to detect conflicting Linux SDKs for global installs and ad…

    …d vscode/sudo for sudo commands
    root authored and nagilson committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e70ddc4 View commit details
    Browse the repository at this point in the history
  2. Break up the install verification into smaller functions. Next, check…

    … the sudo fuctionality
    root authored and nagilson committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2a8d4cf View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. use promise instead of void

    nagilson committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2649db1 View commit details
    Browse the repository at this point in the history
  2. Add distro-data and json parsing code, fix sudo parsing code (needs t…

    …o be tested more to see command output and results not on admin), and add nornt option to skip building the runtime ext
    nagilson committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    568a953 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Add WSL detection for running sudo or not, wrap the sudo lib to make …

    …it synchronous, add a base implementation for every single command.
    nagilson committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a3dc8c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Fix some basic bugs with command parsing logic.

    installcommand works up to replacing the {0}, which should be fixed now, check runcommand on wsl and such
    nagilson committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    054aa64 View commit details
    Browse the repository at this point in the history
  2. Bug fixes for global install, fix ubuntu json versions, add space in …

    …sudo command, and fix replacement
    nagilson committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d277088 View commit details
    Browse the repository at this point in the history
  3. Force error on WSL because we cant run sudo through exec sync without…

    … having and forwarding the user password
    nagilson committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5606419 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    63599b8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b1f98d1 View commit details
    Browse the repository at this point in the history
  6. ALL Linux Distro Tests pass!

    nagilson committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6e2c3ce View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Add tests for the version resolver and fix version bugs. Rename Linux…

    …Resolver and make it easier to test.
    
    Need to fix the remaining bug in detecting if valid or fully specified version
    nagilson committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    015cbba View commit details
    Browse the repository at this point in the history
  2. fix a bug with the version resolver where itd not find bad patch vers…

    …ions. Pass all tests!
    nagilson committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    80dd621 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Configuration menu
    Copy the full SHA
    10dab4e View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Configuration menu
    Copy the full SHA
    8b4e207 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    370f3f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Example

    sfoslund authored and nagilson committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    09f21ce View commit details
    Browse the repository at this point in the history
  2. Bump vscode versions so that vsce package succeeds on the sample exte…

    …nsion
    
    VSCode added support for no activiation events in vsce with 1.74.0, the vsce package will fail until this update was added to bump vscode engine in the sample extension. VSCE is also deprecated and you must use @vscode/vsce now.
    nagilson committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    3429290 View commit details
    Browse the repository at this point in the history
  3. Make all of the linux version resolver tests pass

    We needed to add the mock executor to the mock distro provider so we could see if it tried to run the install command or the update command. I also added a test to see if things are rejected (when you try to install a lower major.minor than what's already on the machine) but we should see if we want that behavior by checking in with the PMs on the team!
    nagilson committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    9f67837 View commit details
    Browse the repository at this point in the history
  4. Prevent Running Sample Extension as a .VSIX

    We needed to create a sample extension VSIX for testing but now we want to allow debugging it again, so this reverts that part of the commit. We didnt just revert the commit as it included changes to vscode versions needed to run
    nagilson committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d2c8d34 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Implement tests for Global Installer Resolver. Rename classes to be s…

    …dk and runtime agnostic.
    
    Since classes will be running a global install of the sdk and the runtime in the future, it makes sense to rename them now. The word SDK also makes them more verbose.
    
    This implements the tests for the global installer resolver. It also makes improvements to said resolver I observed while testing. We never needed, to check for mac conflicting installs as they would be caught by the mac installer.
    
    I added a file for the windows and mac installer tests that will be implemented soon.
    nagilson committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f2dd236 View commit details
    Browse the repository at this point in the history
  2. Add documentation we had internally to the repository.

    This is so it can be read during PR Review and by the public. Thank you to many who contributed their thoughts, including but not limited to @baronfel, @rlander, and @leecow.
    nagilson committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    6228bd0 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Fix Windows Registry Check and Add Tests For It

    This also removes some of the remaining todo checks that required verifying that things worked.
    
    The windows and mac install tests are failing. Those 2 still need to be fixed.
    nagilson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    624b2d1 View commit details
    Browse the repository at this point in the history
  2. Pass all windows and mac installer tests and fix exposed bugs

    The directory deletion did not work correctly and the file download would throw with concurrent requests which has been fixed. Passes all library tests. Next the end to end tests should be fixed, todos checked, and code cleaned up.
    nagilson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    b041e1c View commit details
    Browse the repository at this point in the history
  3. Fix the PATH Logic for Global Installs and E2E Test.

    The e2e test has added an option to not actually do the install via the environment variable `VSCODE_DOTNET_GLOBAL_INSTALL_FAKE_PATH`. We dont want to run the install as it'd put things on our build machines and quickly escalate into a disaster for other repositories.
    
    We now set the PATH for a global install because there is no linux installer that sets the path.
    
    This also includes minor improvements to other tests like using assert.includes instead of just asserting is true and checking substring.includes.
    nagilson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    047bcc8 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Add a document describing the global installs

    We added this to assist in the reviewing process.
    nagilson committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    babf6a9 View commit details
    Browse the repository at this point in the history
  2. Add images to the global install change document

    Also expanded the details for why we use a distro json file.
    nagilson committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    a849b2e View commit details
    Browse the repository at this point in the history
  3. Fix Installer Status Code Handling + Partial Installs

    We do not have logic to do an uninstall for the global install yet, but it's good to be able to check for a partial install and log it nontheless, which is what we do here.
    
    We fixed the windows installer to use the installer status exit code instead of stdout because the windows installer does not print to stdout or stderr. We also dont want to fail on reboot success codes.
    
    We also cleaned up code by removing unneeded includes. Moving a test string into a file.
    nagilson committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    ae4fe99 View commit details
    Browse the repository at this point in the history