Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:GoogleCalendarにイベントを追加するコマンド #6

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

peijun
Copy link
Member

@peijun peijun commented Aug 8, 2020

CALENDAR_WEBHOOKはIFTTTのもの

@peijun peijun requested review from sh1ma and chun37 August 8, 2020 12:08
@peijun peijun linked an issue Aug 8, 2020 that may be closed by this pull request
@peijun peijun self-assigned this Aug 9, 2020
Copy link
Member

@chun37 chun37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作させた?
フォーマッター通した?

.env-example Outdated Show resolved Hide resolved
logic/calendar.py Outdated Show resolved Hide resolved
plugin/calendar.py Outdated Show resolved Hide resolved
logic/calendar.py Outdated Show resolved Hide resolved
@peijun
Copy link
Member Author

peijun commented Aug 9, 2020

@chun37 レビュー感謝

@peijun peijun requested a review from chun37 August 9, 2020 22:21
Copy link
Member

@chun37 chun37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良くなったと思う。
あと import のソートもお願いしたいです。

logic/calendar.py Outdated Show resolved Hide resolved
logic/calendar.py Outdated Show resolved Hide resolved
tests/test_calendar.py Outdated Show resolved Hide resolved
@chun37
Copy link
Member

chun37 commented Aug 9, 2020

Web Request についてだけど、requests を入れるか urllib.request を使うかどちらが良いのだろう

@chun37 chun37 mentioned this pull request Aug 10, 2020
@peijun
Copy link
Member Author

peijun commented Aug 10, 2020

Web Request についてだけど、requests を入れるか urllib.request を使うかどちらが良いのだろう

現状ここでしかhttp requestしないから標準ライブラリでいいかなと

@peijun peijun requested a review from chun37 August 11, 2020 09:20
@peijun
Copy link
Member Author

peijun commented Aug 11, 2020

@chun37
webhookをazure functionsで自作したものに変更しました。
コード自体はあとで別リポジトリで公開する予定です(なかよしがいい?)
レビューお願いします

Copy link
Member

@chun37 chun37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードの内容的には問題無いと思う。
引数が多いのどうにかしたいと思った。
今後も増えたり減ったりする可能性あるし、dataclass とか使えばいいかなと思った。
どう?

logic/calendar.py Outdated Show resolved Hide resolved
logic/calendar.py Outdated Show resolved Hide resolved
@chun37
Copy link
Member

chun37 commented Aug 13, 2020

GoogleCalenderImpl を使ってるので、CalenderImpl の必要ってあるのかな

Copy link
Member

@chun37 chun37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pylint 見てる?

logic/calendar.py Outdated Show resolved Hide resolved
logic/calendar.py Show resolved Hide resolved
logic/calendar.py Show resolved Hide resolved
logic/calendar.py Outdated Show resolved Hide resolved
logic/calendar.py Show resolved Hide resolved
logic/calendar.py Show resolved Hide resolved
logic/calendar.py Outdated Show resolved Hide resolved
logic/calendar.py Outdated Show resolved Hide resolved
logic/calendar.py Show resolved Hide resolved
@peijun peijun requested a review from chun37 August 16, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google カレンダーにイベントを追加するコマンド
3 participants