-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:GoogleCalendarにイベントを追加するコマンド #6
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
動作させた?
フォーマッター通した?
review suggestion change envname Co-authored-by: chun <[email protected]>
Co-authored-by: chun <[email protected]>
Co-authored-by: chun <[email protected]>
Co-authored-by: chun <[email protected]>
Co-authored-by: chun <[email protected]>
@chun37 レビュー感謝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良くなったと思う。
あと import のソートもお願いしたいです。
Web Request についてだけど、requests を入れるか urllib.request を使うかどちらが良いのだろう |
Co-authored-by: chun <[email protected]>
現状ここでしかhttp requestしないから標準ライブラリでいいかなと |
WEBHOOKを自作のものに変更
@chun37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コードの内容的には問題無いと思う。
引数が多いのどうにかしたいと思った。
今後も増えたり減ったりする可能性あるし、dataclass とか使えばいいかなと思った。
どう?
GoogleCalenderImpl を使ってるので、CalenderImpl の必要ってあるのかな |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pylint 見てる?
CALENDAR_WEBHOOKはIFTTTのもの