[AWS-EC2] Add support for EC2 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FINALLY!!!!
Completed: - `meta` controller (integration tests) - `keys` controller (integration tests) TODO: - `servers` controller (integration tests) - all adapters (unit tests) - all tasks (unit tests) - `models` utility (unit tests) - `output` utility (unit tests)
Disable testing `azure` Classic, as it appears to fnally be phasing out, properly, on Microsoft's side. The adapter itself will be fully removed at a later date.
Completed: - `meta` controller (integration tests) - `keys` controller (integration tests) - `servers` controller (integration tests) - `models` utility (unit tests) - `output` utility (unit tests) TODO: - all adapters (unit tests) - all tasks (unit tests)
Wanted to test even the base adapter, mostly to cut down on the sheer amount of stuff being tested in each adapter's own implementation. If it works in the base, and we don't override it in the provider-specific, then we shouldn't have to test it again there.
Ensure we're still doing things the same way in the new adapter that we were in the old one. This is in preparation for layering in new features for the adapter, and from there, doing similar for other adapters as well.
Libcloud doesn't provide this info, so we have to grab it directly ourselves, still. So we'll also cache the results for 24 hours, to keep things nice and fast.
- Add support for specifying a VPC ID, and Availability Zone distribution, via custom configuration values passed during server creation.
- Find or create resources needed to properly set up servers as required for Nanobox.
- Create and honor `Nanobox: {boolean}` tags. `true` means "prefer this resource", while `false` means "this resource is unavailable".
Assume PV if the generation isn't known.
…en't seen it before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a plethora of new features for everyone!