Logging: add user-adjustable log levels ("err", "warn", "info") #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 721d2b9 removed the fs_status enum and the string_from_fs_status() function. Adapt the tracelog code to use standard error numbers.
When a network socket is created via the socket() syscall, the supplied type is checked against supported types, so that it is not possible to create a socket with a non-supported type; therefore, there is no need to check for non-supported types in the socket callbacks.
The unix file cache is an objcache, thus it returns INVALID_ADDRESS on allocation failure.
The log_printf() function now takes an enum log_level parameter,
and prints the message to the console if the supplied level is
lower than or equal than the configured kernel log level (which can
be set via the "log_level" manifest option). The default log level
is "err".
The msg_{err,warn,info} macros have been repurposed so that in
kernel code they expand to log_printf() function calls; calls to
these macros have been modified so that the format string starts
with a sensible prefix; the trailing newline is added by
log_printf(), thus it has been removed from the macro invocations.
Some rprintf() and thread_log() calls have been converted to use
the msg_{print,err,warn,info} macros.
eyberg
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The msg_{err,warn,info} macros have been repurposed so that in kernel code they expand to log_printf() function calls, which print the supplied message to the console if the log level (supplied as an additional argument) is lower than or equal to the configured kernel log level. The default log level is "err".
Example Ops configuration to set the log level to "info":