Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase configuration options and fix bugs after the python3 upgrade #384

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

teresalves
Copy link

Related to this issue:
#382

Summing up, this PR fixes several problems:

  • Lack of configurability for the kafka publishers, which are particularly useful for higher payloads
  • Adding a backlog option for the internal zmq configurations, since the default is somewhat low
  • the python3 kafka producer only accepts bytes and the zmq only accepts strings. So we had to encode the strings in the kafka publisher
  • The "metrics_include_attributes" were new are really heavy, so they were set to False by default (people can still turn them on) - prometheus might not like this new inflow so we should just turn them on if needed.
  • changed some logs from info to debug because they were not adding a lot of value when in info and ended up just spamming the logs

We have tested these changes on our side (although the kafka opts were hardcoded in a patch and not added thgough the configs)

The docs here were updated to contemplate these changes too.

Let me know what you think @mirceaulinic 😄

@teresalves teresalves force-pushed the teresalves/fix-python3-inconsistencies branch from a7e57a0 to b939ba8 Compare May 10, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant