fix(metadata-explorer.ts): fix missing props from base class

nartc · Feb 10, 2020 · 2e4ec7d · 2e4ec7d
1 parent 3adaf85
commit 2e4ec7d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/metadata-explorer.ts b/src/metadata-explorer.ts
@@ -60,8 +60,14 @@ class MetadataManager {
     model: TModel,
     metadata: MetadataMapList<TModel>
   ) {
+    const existingMetadata = this._metadataMap.get(model) || [];
+    const existingProtoMetadata = Object.getPrototypeOf(model)
+      ? this._metadataMap.get(Object.getPrototypeOf(model)) || []
+      : [];
+
     this._metadataMap.set(model, [
-      ...(this._metadataMap.has(model) ? this.getMetadata(model) : []),
+      ...existingProtoMetadata,
+      ...existingMetadata,
       ...metadata,
     ]);
   }

diff --git a/test/metadata-manager.test.ts b/test/metadata-manager.test.ts
@@ -2,6 +2,13 @@ import { AutoMap } from '../src';
 import { instantiate } from '../src/metadata-explorer';
 
 describe('MetadataManager', () => {
+  class Base {
+    @AutoMap()
+    createdAt!: Date;
+    @AutoMap()
+    updatedAt!: Date;
+  }
+
   class Address {
     @AutoMap()
     street!: string;
@@ -11,7 +18,7 @@ describe('MetadataManager', () => {
     state!: string;
   }
 
-  class User {
+  class User extends Base {
     @AutoMap()
     firstName!: string;
     @AutoMap()