Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks #33

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Add pre-commit hooks #33

merged 2 commits into from
Aug 2, 2024

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Aug 2, 2024

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.06%. Comparing base (52f5c7d) to head (4ef8bdb).
Report is 4 commits behind head on main.

Files Patch % Lines
gcn_kafka/core.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   76.85%   76.06%   -0.80%     
==========================================
  Files           7        7              
  Lines         121      117       -4     
==========================================
- Hits           93       89       -4     
  Misses         28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dakota002
Copy link
Contributor

It looks good, the only thing that failed was 1 line that it says isn't covered

@lpsinger lpsinger merged commit 9f19710 into nasa-gcn:main Aug 2, 2024
18 of 19 checks passed
@lpsinger lpsinger deleted the pre-commit branch August 2, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants