Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to stable uswds and nasawds releases #2306

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

lpsinger
Copy link
Member

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 5.23%. Comparing base (8791d85) to head (03939b5).

Current head 03939b5 differs from pull request most recent head c4e1554

Please upload reports for the commit c4e1554 to get more accurate results.

Files Patch % Lines
...tes/circulars._archive._index/DateSelectorMenu.tsx 0.00% 1 Missing ⚠️
...s/circulars._archive._index/SortSelectorButton.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2306   +/-   ##
=====================================
  Coverage   5.23%   5.23%           
=====================================
  Files        155     155           
  Lines       3803    3803           
  Branches     400     400           
=====================================
  Hits         199     199           
  Misses      3601    3601           
  Partials       3       3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- uswds/uswds#5825 has been fixed.
- https://github.com/lpsinger/react-uswds/tree/gcn is the same as
  trussworks/react-uswds#2726, but rebased.
- I had to update some CSS where we have heavily customized the
  appearance of some USWDS components.
Copy link
Contributor

@dakota002 dakota002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lpsinger lpsinger merged commit 960ac15 into nasa-gcn:main Jun 1, 2024
10 checks passed
@lpsinger lpsinger deleted the uswds-stable branch June 1, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants