-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Add BlockInlineImage
component
#35
Conversation
still need to add Fancybox lightbox modal (WIP)
removing extra =
@laespinoza86 What do you think about finishing this up without Fancybox? Not sure how soon we'll get that in given other tasks this week and next. |
@stephiescastle I actually started working on |
BlockInlineImage
componentBlockInlineImage
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @laespinoza86! I had one non-blocking thought about where to insert the space for the BaseImageCaption
computedClass
.
storybook/stories/components/BaseImageCaption/BaseImageCaption.js
Outdated
Show resolved
Hide resolved
adding a space
Checklist
Description
Adding
BlockInlineImage
to our components list.Instructions to test
npm run storybook
View it under
Components > Blocks > BlockInlineImage
http://localhost:6006/?path=/docs/components-blocks-blockinlineimage--align-right
WWW Storybook equivalent: https://designlab.jpl.nasa.gov/storybook/?path=/docs/components-blocks-blockinlineimage--align-right
Tested in the following environments/browsers:
Operating System
Browser