Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add BlockInlineImage component #35

Merged
merged 10 commits into from
Oct 5, 2021

Conversation

laespinoza
Copy link
Contributor

@laespinoza laespinoza commented Sep 29, 2021

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Adding BlockInlineImage to our components list.

Instructions to test

  1. Pull this branch
  2. npm run storybook

View it under Components > Blocks > BlockInlineImage
http://localhost:6006/?path=/docs/components-blocks-blockinlineimage--align-right

WWW Storybook equivalent: https://designlab.jpl.nasa.gov/storybook/?path=/docs/components-blocks-blockinlineimage--align-right

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added documentation Improvements or additions to documentation storybook This issue relates to Storybook.js labels Sep 29, 2021
@laespinoza laespinoza mentioned this pull request Sep 29, 2021
31 tasks
@laespinoza laespinoza self-assigned this Sep 30, 2021
@stephiescastle
Copy link
Member

@laespinoza86 What do you think about finishing this up without Fancybox? Not sure how soon we'll get that in given other tasks this week and next.

@laespinoza
Copy link
Contributor Author

laespinoza commented Sep 30, 2021

@stephiescastle I actually started working on BlockImage and didn't realize that also needs Fancybox, so I have started adding it to that branch and will have a PR up soon! Doing some final testing. Once we get that merged in i'll wrap up this PR and move it out of draft.

@laespinoza laespinoza changed the title (WIP) Storybook: Add BlockInlineImage component Storybook: Add BlockInlineImage component Oct 4, 2021
@laespinoza laespinoza marked this pull request as ready for review October 5, 2021 19:14
Copy link
Member

@stephiescastle stephiescastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @laespinoza86! I had one non-blocking thought about where to insert the space for the BaseImageCaption computedClass.

adding a space
@laespinoza laespinoza merged commit 92f1e7e into main Oct 5, 2021
@laespinoza laespinoza deleted the docs/storybook/blockinlineimage branch October 5, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants