Fixed silkscreen for J18

[abust005]

Silkscreen for J18 (RC3 Motor Supply) was inconsistent with the net going to those pins

[ericjunkins]

Can I ask what the scope of this MR is? The title is fixing silk screen and has a commit for that which @apollokit was to review (I think he was out of town, maybe still is). But now I see the WireViz diagrams being added too. I think it would be cleaner to keep those for a separate MR and to do just the silkscreen update here.

[ericjunkins]

I'm happy to do the review of the silkscreen instead and could do that soon to get this MR in though

[abust005]

Thank you for bringing this to my attention, the WireViz diagrams should not have ended up in this MR.

[ericjunkins]

oh, these changes are made with a newer version of KiCAD than we were previously using. I think in general I have opposition to upgrading KiCAD version. @abust005 you didn't have any import issues in moving forward in version?

[abust005]

@ericjunkins I did notice it was a newer version because KiCAD told me, but I was unsure as to what the version currently in use is.

As far as import issues, I'm not aware of any; I didn't run the DRC on anything, but I was able to get the boards fabbed with no issues

[ericjunkins]

We noticed we were a bit behind on KiCAD versions when we started designing this rev but decided not to upgrade in case we had compatibility issues. But It seems if there isn't an issue then I see no reason not to.

[abust005]

I'm far from an expert on the matter, so I can't speak very much to any compatibility issues or lack thereof, I can only offer my own anecdotal experience :)

[ericjunkins]

Looks good to me, here's a quick screencap for everyone else of the component in question and the silkscreen corrected.

I have another request looking at this, can you increment the silkscreen pcb version as well? This would be v2.0.3 and has a silkscreen label on both of the boards that need updated.

[abust005]

Updated version silkscreen per request

[ericjunkins]

Approved!

[Achllle]

@sethfischer Noticing that the readthedocs build is failing due to

Problem in your project's configuration. No default configuration file found at repository's root.

I will merge this in since it's entirely unrelated, but wanted to check if you knew what may be causing this.

[ericjunkins]

Thanks for the fix @abust005 !

[sethfischer]

@sethfischer Noticing that the readthedocs build is failing due to

Problem in your project's configuration. No default configuration file found at repository's root.

Read the Docs failed to build this branch because the branch was created off master before #430 was merged.

A git fetch upstream and git rebase upstream master would have allowed the docs to build for this branch.