-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve instructions for rocker-bogie assemblies, add more pictures #453
Improve instructions for rocker-bogie assemblies, add more pictures #453
Conversation
Looks good, just a pair of thoughts: In the new image Also I notice that the servo is facing the wrong way there, which isn't a huge deal, but the ribbon cable strain relief is facing away from the wiring drawing. |
Yeah, it's a bit lazy. I think a picture would be much better but I didn't have a good one. |
@abust005 Addressed your comment. Let me know if you think something else could be improved! |
Looks pretty good to me! I'll sign off on this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feedback would be that the pictures look great and more descriptive. As I didn't build the V2 version of your rocker bogie I don't know if i'm fully qualified to say it addressed the issues that necessitated the PR though.
Agree, looks good, but I haven't built this version yet |
Ok, I'll merge this in because it's better than what was there before and we can improve it as comments come in. Thanks for the feedback everyone! |
No description provided.