Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instructions for rocker-bogie assemblies, add more pictures #453

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

Achllle
Copy link
Collaborator

@Achllle Achllle commented Feb 18, 2024

No description provided.

@abust005
Copy link
Collaborator

Looks good, just a pair of thoughts:

In the new image front_servo_to_rb.png, there's a drawing that I imagine is intended to show how wiring should be routed, but it seems a little too abstract; I thought it might've been a scribble.

Also I notice that the servo is facing the wrong way there, which isn't a huge deal, but the ribbon cable strain relief is facing away from the wiring drawing.

@Achllle
Copy link
Collaborator Author

Achllle commented Feb 24, 2024

Yeah, it's a bit lazy. I think a picture would be much better but I didn't have a good one.
Good catch on the onshape model. I'll have to flip it, I hadn't noticed that.

@Achllle
Copy link
Collaborator Author

Achllle commented Mar 3, 2024

@abust005 Addressed your comment. Let me know if you think something else could be improved!

@abust005
Copy link
Collaborator

abust005 commented Mar 3, 2024

Looks pretty good to me! I'll sign off on this one

Copy link
Collaborator

@ericjunkins ericjunkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feedback would be that the pictures look great and more descriptive. As I didn't build the V2 version of your rocker bogie I don't know if i'm fully qualified to say it addressed the issues that necessitated the PR though.

@apollokit
Copy link
Collaborator

My feedback would be that the pictures look great and more descriptive. As I didn't build the V2 version of your rocker bogie I don't know if i'm fully qualified to say it addressed the issues that necessitated the PR though.

Agree, looks good, but I haven't built this version yet

@Achllle
Copy link
Collaborator Author

Achllle commented Mar 7, 2024

Ok, I'll merge this in because it's better than what was there before and we can improve it as comments come in. Thanks for the feedback everyone!

@Achllle Achllle merged commit e28eb96 into nasa-jpl:master Mar 7, 2024
2 checks passed
@Achllle Achllle deleted the rocker-bogie-doc-improvements branch March 7, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants