Fix #288, Remove unnecessary CF_UnionArgs_Payload_t union #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| ret = fn(cmd->data.byte[0], context); | ||
| ret = fn(cmd->byte[0], context); |
Check notice
Code scanning / CodeQL-coding-standard
Use of non-constant function pointer
|
CCB:2023.03.09: Note that padding may not be aligned from this change. |
|
Hey @thnkslprpt, would you be able to resolve the conflicts? Thanks! |
thnkslprpt
force-pushed
the
fix-288-remove-CF_UnionArgs_Payload_t-union
branch
from
6d4e366
to
7c1a590
Compare
thnkslprpt
force-pushed
the
fix-288-remove-CF_UnionArgs_Payload_t-union
branch
from
7c1a590
to
d3af9ca
Compare
Should be done now @dzbaker |
dzbaker
added a commit
that referenced
this pull request
Jul 11, 2023
2 tasks
dzbaker
added a commit
to dzbaker/CF
that referenced
this pull request
Jul 11, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #288
CF_UnionArgs_Payload_thas been removed, given that only a single member of the 3 is used in CF. That member variable -byte- has been moved into theCF_UnionArgsCmd_tstruct, which was the only place whereCF_UnionArgs_Payload_twas used.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No impact on logic.
Contributor Info
Avi Weiss @thnkslprpt